Skip to content

fix: DSL should not be displayed without wired network devices #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caixr23 merged 1 commit into from
Apr 17, 2025
Merged

fix: DSL should not be displayed without wired network devices #331

caixr23 merged 1 commit into from
Apr 17, 2025

Conversation

@caixr23
Copy link
Contributor

@caixr23 caixr23 commented Apr 17, 2025 •
edited by sourcery-ai bot
Loading

DSL should not be displayed without wired network devices

pms: BUG-311983

Summary by Sourcery

Modify DSL network item visibility to only show when wired network devices are present

Bug Fixes:

  • Prevent DSL network item from being displayed when no wired network devices are available

Enhancements:

  • Add a new method to dynamically control DSL item visibility based on network device presence

@caixr23
fix: DSL should not be displayed without wired network devices
7c58756 
DSL should not be displayed without wired network devices

pms: BUG-311983
@deepin-ci-robot
Copy link

deepin-ci-robot commented Apr 17, 2025

deepin pr auto review

关键摘要:

  • 在PageDSL.qml文件中，visible属性从item更改为item.enabledable，需要确认enabledable是否是正确的属性名。
  • 在netmanagerthreadprivate.cpp文件中，移除了对vpnController的连接，但未移除相关的注释代码，建议清理未使用的代码。
  • 在NetManagerThreadPrivate::updateDSLEnabledable函数中，当检测到有线设备时，直接返回并设置NetDSLControlItem为可用，这可能不是预期的行为，应该检查逻辑是否正确。
  • 在NetManagerThreadPrivate::onDeviceAdded和NetManagerThreadPrivate::onDeviceRemoved函数中，每次设备添加或移除时都调用updateDSLEnabledable，这可能会导致不必要的重复更新，建议优化这部分逻辑。

是否建议立即修改:
是

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 17, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caixr23 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like updateDSLEnabledable could be extracted to a separate file/class to improve separation of concerns.
  • Consider adding a comment to explain why NetType::NetManagerFlag::Net_DSL is checked multiple times.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 17, 2025

Reviewer's Guide by Sourcery

This pull request ensures that the DSL network configuration is only displayed when there are wired network devices available. It achieves this by adding a function that checks for wired network devices and emits a signal to update the visibility of the DSL configuration. The function is called when devices are added or removed. The pull request also removes unused VPN-related code.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Conditionally display the DSL network configuration based on the presence of wired network devices.
  • Added updateDSLEnabledable function to control the visibility of the DSL configuration.
  • The DSL configuration is now only displayed when at least one wired network device is available.
  • The updateDSLEnabledable function is called when devices are added or removed.
 net-view/operation/private/netmanagerthreadprivate.cpp
dcc-network/qml/PageDSL.qml
net-view/operation/private/netmanagerthreadprivate.h
Removed unused VPN-related code.
  • Removed unused vpnControlItem variable.
  • Removed commented-out signal/slot connections related to VPN enable changes.
 net-view/operation/private/netmanagerthreadprivate.cpp
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin-ci-robot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit 952e7b6 into linuxdeepin:master Apr 17, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@robertkill robertkill robertkill approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caixr23 @deepin-ci-robot @robertkill