feat: enhance notification validation and cleanup

1. Added isValid() method to BubbleItem to check entity validity
2. Implemented clearInvalidBubbles() in BubbleModel to remove invalid
notifications
3. Added entity validation before creating new bubbles in BubblePanel
4. Enhanced NotifyEntity validation to include timestamp check
5. Added validation in NotificationManager timeout processing
6. Added debug logging for invalid notification cases

These changes improve notification system reliability by:
- Preventing invalid notifications from being displayed
- Cleaning up stale notifications automatically
- Adding better error handling and logging
- Preventing race conditions in timeout processing
- Ensuring only valid entities are processed

feat: 增强通知验证和清理功能

1. 在 BubbleItem 中添加 isValid() 方法检查实体有效性
2. 在 BubbleModel 中实现 clearInvalidBubbles() 清理无效通知
3. 在 BubblePanel 创建新气泡前添加实体验证
4. 增强 NotifyEntity 验证包含时间戳检查
5. 在 NotificationManager 超时处理中添加验证
6. 为无效通知情况添加调试日志

这些改进通过以下方式提升通知系统可靠性：
- 防止显示无效通知
- 自动清理陈旧通知
- 添加更好的错误处理和日志记录
- 防止超时处理中的竞态条件
- 确保只处理有效实体

Issue: https://bbs.deepin.org/post/289141

Author: 18202781743

panels/notification/bubble/bubbleitem.cpp

@@ -317,6 +317,11 @@ void BubbleItem::setEnablePreview(bool enable)
     m_enablePreview = enable;
 }
 
+bool BubbleItem::isValid() const
+{
+    return m_entity.isValid();
+}
+
 QString BubbleItem::displayText() const
 {
     return m_enablePreview ? m_entity.body() : tr("1 new message");

panels/notification/bubble/bubbleitem.h

@@ -48,6 +48,8 @@ class BubbleItem : public QObject
     bool enablePreview() const;
     void setEnablePreview(bool enable);
 
+    bool isValid() const;
+
 signals:
     void levelChanged();
     void timeTipChanged();

panels/notification/bubble/bubblemodel.cpp

@@ -284,6 +284,16 @@ void BubbleModel::setDelayRemovedBubble(qint64 newDelayRemovedBubble)
     emit delayRemovedBubbleChanged();
 }
 
+void BubbleModel::clearInvalidBubbles()
+{
+    for (int i = m_bubbles.count() - 1; i >= 0; i--) {
+        auto bubble = m_bubbles.at(i);
+        if (!bubble->isValid()) {
+            remove(bubble);
+        }
+    }
+}
+
 int BubbleModel::replaceBubbleIndex(const BubbleItem *bubble) const
 {
     if (bubble->isReplace()) {

panels/notification/bubble/bubblemodel.h

@@ -64,6 +64,8 @@ class BubbleModel : public QAbstractListModel
     qint64 delayRemovedBubble() const;
     void setDelayRemovedBubble(qint64 newDelayRemovedBubble);
 
+    void clearInvalidBubbles();
+
 signals:
     void delayRemovedBubbleChanged();
 

panels/notification/bubble/bubblepanel.cpp

@@ -116,6 +116,13 @@ void BubblePanel::onBubbleCountChanged()
 void BubblePanel::addBubble(qint64 id)
 {
     const auto entity = m_accessor->fetchEntity(id);
+
+    // Validate entity before creating bubble to prevent invalid notification banners
+    if (!entity.isValid()) {
+        qWarning(notifyLog) << "Failed to add bubble: invalid entity for id" << id << "appName:" << entity.appName() << "cTime:" << entity.cTime();
+        return;
+    }
+
     auto bubble = new BubbleItem(entity);
     const auto enabled = enablePreview(entity.appId());
     bubble->setEnablePreview(enabled);
@@ -135,11 +142,15 @@ void BubblePanel::closeBubble(qint64 id)
     if (entity.isValid()) {
         id = entity.bubbleId();
     } else {
+        qDebug(notifyLog) << "Entity not found or invalid for close bubble, using storage id lookup:" << id;
         id = m_bubbles->getBubbleIdByStorageId(id);
     }
 
     if (id > 0) {
         m_bubbles->removeById(id);
+    } else {
+        qWarning(notifyLog) << "Failed to close bubble: invalid bubble id for entity id:" << id << "appName:" << entity.appName() << "cTime:" << entity.cTime();
+        clearInvalidBubbles();
     }
 }
 
@@ -172,6 +183,11 @@ bool BubblePanel::enablePreview(const QString &appId) const
     return value.toBool();
 }
 
+void BubblePanel::clearInvalidBubbles()
+{
+    m_bubbles->clearInvalidBubbles();
+}
+
 BubbleItem *BubblePanel::bubbleItem(int index)
 {
     if (index < 0 || index >= m_bubbles->items().count())

panels/notification/bubble/bubblepanel.h

@@ -57,6 +57,7 @@ private Q_SLOTS:
     void onBubbleClosed(qint64 id, uint bubbleId, uint reason);
     void setVisible(const bool visible);
     bool enablePreview(const QString &appId) const;
+    void clearInvalidBubbles();
 
     BubbleItem *bubbleItem(int index);
 

panels/notification/common/notifyentity.cpp

@@ -53,6 +53,7 @@ NotifyEntity::NotifyEntity(qint64 id, const QString &appName)
 {
     d->id = id;
     d->appName = appName;
+    d->cTime = QDateTime::currentMSecsSinceEpoch();
 }
 
 NotifyEntity::NotifyEntity(const QString &appName, uint replacesId, const QString &appIcon, const QString &summary,
@@ -117,7 +118,7 @@ bool NotifyEntity::operator!=(const NotifyEntity &other) const
 
 bool NotifyEntity::isValid() const
 {
-    return d && d->id > 0;
+    return d && d->id > 0 && d->cTime > 0;
 }
 
 qint64 NotifyEntity::id() const

panels/notification/server/notificationmanager.cpp

@@ -643,6 +643,13 @@ void NotificationManager::onHandingPendingEntities()
     }
 
     for (const auto &item : timeoutEntities) {
+        // Validate entity before processing timeout to prevent race conditions
+        if (!item.isValid()) {
+            qWarning(notifyLog) << "Skipping timeout processing for invalid entity id:" << item.id() << "appName:" << item.appName()
+                                << "cTime:" << item.cTime();
+            continue;
+        }
+
         qDebug(notifyLog) << "Expired for the notification " << item.id() << item.appName();
         notificationClosed(item.id(), item.bubbleId(), NotifyEntity::Expired);
     }