fix: modify when keep hiden animation has launched, has shadow and line. #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideIntroduce conditional logic to D.DWindow properties in the dock panel to remove its shadow and border while the hide/show animation is active, preventing visual artifacts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @wjyrich - I've reviewed your changes - here's some feedback:
- Consider extracting the
hideShowAnimation.runningcondition into a dedicated property (e.g.,isAnimating) to avoid duplicating logic and improve readability. - Replace the numeric literal
0forwindowEffectwith the corresponding named enum/constant to make the default effect clearer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the `hideShowAnimation.running` condition into a dedicated property (e.g., `isAnimating`) to avoid duplicating logic and improve readability.
- Replace the numeric literal `0` for `windowEffect` with the corresponding named enum/constant to make the default effect clearer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
reviewed
Jun 16, 2025
panels/dock/package/main.qml
Outdated
| D.DWindow.enabled: true | ||
| D.DWindow.windowRadius: 0 | ||
| D.DWindow.borderWidth: 1 | ||
| //D.DWindow.windowEffect: hideShowAnimation.running ? D.PlatformHandle.EffectNoShadow : 0 |
Contributor
Author
There was a problem hiding this comment.
也不是， 因为windoweffect没有效果 想着kwin修复了 再修改，我去备注一下
as title. PMS-BUG-313787
deepin pr auto review关键摘要:
是否建议立即修改:
合并相似的问题:
|
18202781743
approved these changes
Jun 17, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 2.0.0 |
|
TAG Bot New tag: 2.0.1 |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: behind) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title.
PMS-BUG-313787
Summary by Sourcery
Disable window shadow and border during the dock hide/show animation
Bug Fixes: