Skip to content

chore: Bump version to 6.0.51#386

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr0305
Mar 5, 2026
Merged

chore: Bump version to 6.0.51#386
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
wangrong1069:pr0305

Conversation

@wangrong1069
Copy link
Contributor

@wangrong1069 wangrong1069 commented Mar 5, 2026

As title.

Log: Bump version to 6.0.51

Summary by Sourcery

Build:

  • Update linglong package manifest to reference version 6.0.51.1.

As title.

Log: Bump version to 6.0.51
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

TAG Bot

TAG: 6.0.51
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the application/package version from 6.0.50.1 to 6.0.51.1 in the linglong packaging configuration, with a corresponding Debian changelog touch (no visible diff content provided).

File-Level Changes

Change Details Files
Update packaged application version metadata to 6.0.51.1.
  • Increment the package.version field in linglong packaging configuration from 6.0.50.1 to 6.0.51.1
  • Ensure version metadata aligns with the intended 6.0.51 release across packaging files (Debian changelog file is included in the PR, though its exact content change is not shown)
linglong.yaml
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这段代码修改主要是针对 deepin-album 项目的版本号更新和打包配置的统一。以下是对该 diff 的详细审查意见:

1. 语法与逻辑审查

  • Debian Changelog (debian/changelog):
    • 格式正确:遵循了标准的 Debian changelog 格式(package (version) distribution; urgency=urgency)。
    • 维护者信息:包含了维护者姓名和邮箱,以及符合 RFC 2822 格式的日期戳。
    • 版本号:版本号 6.0.51 正确递增,符合语义化版本控制规范。
  • Linglong 配置 (linglong.yaml):
    • YAML 语法:语法正确,缩进规范。
    • 版本号一致性linglong.yaml 中的版本号更新为 6.0.51.1
    • 逻辑问题(重要)
      • debian/changelog 中的版本是 6.0.51
      • linglong.yaml 中的版本是 6.0.51.1
      • 不一致性:通常在打包系统中,源码包版本和构建配置版本应保持一致或遵循明确的对应关系。这里的 .1 后缀代表构建号(build number),如果是 Linglong 打包特有的修订号,需要确保 CI/CD 流程能正确处理这种差异。如果两者应该完全一致,这里存在逻辑冲突。

2. 代码质量

  • Commit Message 规范
    • changelog 中使用了 chore: 前缀,符合 Conventional Commits 规范,表示构建过程或辅助工具的变动。
  • 描述清晰度
    • Unify linglong.yaml 这个描述比较模糊。如果是为了同步版本号,建议写为 Bump version to 6.0.51Sync version with debian/changelog。如果是为了统一配置项,应具体说明统一了哪些内容。目前的 diff 仅显示了版本号变化,"Unify" 一词略显不准确。

3. 代码性能

  • 此修改仅涉及元数据和配置文件,不涉及运行时代码,因此对软件运行时的性能(CPU、内存占用、启动速度等)无影响

4. 代码安全

  • 版本号伪造风险:虽然本身不是漏洞,但在发布流程中,必须确保 debian/changeloglinglong.yaml 的版本号是自动且同步生成的。手动修改容易导致版本号回退或混淆,可能影响补丁管理和漏洞追踪。
  • 日期检查debian/changelog 中的日期显示为 2026 年。如果这是当前提交,这是一个明显的错误(除非这是针对未来的计划版本)。错误的日期可能会影响 dpkg-source 等工具的构建行为或导致排序错误。

改进建议

  1. 修正日期

    • 请检查 debian/changelog 中的日期 Thu, 05 Mar 2026。如果是当前提交,请修正为当前实际日期(例如 2024 或 2025 年)。
  2. 统一版本号策略

    • 明确 debian/changelog 版本(6.0.51)与 linglong.yaml 版本(6.0.51.1)的关系。
    • 如果 .1 是 Linglong 的构建修订号,建议在提交信息中注明,例如:chore: Bump version to 6.0.51 (linglong build rev 1)
    • 如果两者应一致,请修改 linglong.yamlversion: 6.0.51
  3. 优化提交信息

    • 建议将 changelog 中的描述改为更具体的描述,如 Update version to 6.0.51,这样比 "Unify" 更能准确反映变更内容。
  4. 自动化同步

    • 建议在 CI/CD 流程中引入脚本,在发布时自动同步 debian/changeloglinglong.yaml 中的版本号,避免人工操作失误。

总结

该 diff 主要是版本更新操作,语法上没有问题。主要问题在于日期年份异常(2026年)以及两个配置文件中版本号格式不一致(是否有意为之)。建议修正日期并明确版本号管理策略。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 5, 2026

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 229a7e3 into linuxdeepin:master Mar 5, 2026
18 of 20 checks passed
@wangrong1069 wangrong1069 deleted the pr0305 branch March 5, 2026 11:58
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 5, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.51
  • Tag SHA: 9b7f16ab7693c08deb55583ea3a8474e03cb2b91
  • Commit SHA: 1d60f6dfa9a7f809518a6ec3cba6c3e6bcb7adcc
  • Tag Message:
    Release deepin-album 6.0.51
    
    
  • Tagger:
    • Name: wangrong1069
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants