Skip to content

sync: from linuxdeepin/dtkwidget#132

Closed
deepin-ci-robot wants to merge 1 commit intomasterfrom
sync-pr-654-nosync
Closed

sync: from linuxdeepin/dtkwidget#132
deepin-ci-robot wants to merge 1 commit intomasterfrom
sync-pr-654-nosync

Conversation

@deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#654

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#654
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DAlertControl 类中的 setMessageAlignmentmessageAlignment 方法被重命名为 setAlertAlignmentalertAlignment,但注释中仍然提到 setMessageAlignment,这可能会导致混淆。
  • DLineEdit 类中新增的 setAlertAlignmentalertAlignment 方法应该更新注释,以反映它们与 DAlertControl 类中的新方法的一致性。
  • DAlertControl 类中的 showAlertMessage 方法现在设置了 d->tooltip->setAlignment(d->messageAlignment);,这表明 messageAlignment 已经被添加到 DAlertControlPrivate 类中,但 setAlertAlignmentalertAlignment 的注释中仍然提到 setMessageAlignment,这可能会导致混淆。

是否建议立即修改:

  • 应该立即更新注释,以反映 setMessageAlignmentmessageAlignment 方法已经被重命名为 setAlertAlignmentalertAlignment
  • 应该确保 DLineEdit 类中的新增方法与 DAlertControl 类中的新方法保持一致,并更新相应的注释。
  • 如果 messageAlignment 是一个新的属性,那么应该在 DAlertControlPrivate 类中添加相应的注释,说明它的用途和默认值。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 17, 2025

TAG Bot

New tag: 6.0.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #133

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 8, 2025

TAG Bot

New tag: 6.0.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #139

@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 19, 2025

TAG Bot

New tag: 6.0.36
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #140

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 19, 2025

TAG Bot

New tag: 6.0.37
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #146

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2025

TAG Bot

New tag: 6.0.38
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #148

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 3, 2025

TAG Bot

New tag: 6.0.39
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #152

@18202781743 18202781743 closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants