Skip to content

Commit 42aff30

Browse files
Add Cookie Consent attribute to LFX Footer (#457)
* feat: upgrade Angular 11→13 and lfx-ui-core to support optional chaining - Upgraded Angular from 11.2.14 to 13.4.0 - Updated @linuxfoundation/lfx-ui-core from 0.0.12 to 0.0.19 - Updated TypeScript from 4.1.6 to 4.6.4 - Updated @auth0/auth0-angular to 2.2.3 for Angular 13 compatibility - Updated ng-bootstrap from 6.2.0 to 12.1.2 - Added @popperjs/core dependency - Configured .npmrc to resolve FontAwesome registry issues - Added allowedCommonJsDependencies configuration - Build now succeeds with optional chaining syntax (?.operator) - Latest LFX UI Core features are now available - Clean builds with no parsing errors Signed-off-by: ahmedomosanya <[email protected]> * feat: add cookie consent attribute to LFX footer Signed-off-by: ahmedomosanya <[email protected]> * fix: update Node.js engine requirement to >=18.0.0 for AWS SDK v3 compatibility Signed-off-by: ahmedomosanya <[email protected]> * fix: update GitHub Actions workflows to use Node.js 18 for AWS SDK v3 compatibility Signed-off-by: ahmedomosanya <[email protected]> * fix: update remaining GitHub Actions workflows to use Node.js 18 Signed-off-by: ahmedomosanya <[email protected]> * fix: resolve Node.js 18 OpenSSL compatibility for edge builds - Update edge package.json engine requirement to >=18.0.0 - Add NODE_OPTIONS=--openssl-legacy-provider to edge build script This fixes the 'digital envelope routines::unsupported' error when building edge Lambda functions with webpack 4 on Node.js 18. Signed-off-by: ahmedomosanya <[email protected]> * fix: resolve yarn audit security vulnerabilities - Add resolutions for @cypress/request, form-data, braces, micromatch, cross-spawn, brace-expansion - Update axios, webpack, esbuild, @babel/runtime, webpack-dev-server to secure versions - Reduce vulnerabilities from 11 critical/high/moderate to 1 moderate (Bootstrap XSS) - yarn_audit.sh now passes (only fails on critical vulnerabilities >=16) The remaining Bootstrap vulnerability requires upgrading to v5 which would be a breaking change for UI components and should be handled in a separate PR. Signed-off-by: ahmedomosanya <[email protected]> * fix: resolve Cypress test vulnerabilities in test/functional directory - Add security resolutions to test/functional/package.json - Fix @cypress/request, form-data, braces, micromatch, cross-spawn, brace-expansion Signed-off-by: ahmedomosanya <[email protected]> * fix: clean up Angular build scripts to use single configuration flags - Remove duplicate configuration flags from build:dev, build:staging, build:prod scripts - Original scripts used --prod --configuration=dev (duplicate configs since --prod = --configuration=production) - ng update converted --prod to --configuration production, making the duplication explicit - Angular CLI was already using last config and showing warning about override - Each environment config in angular.json already includes production optimizations Before: ng build --configuration production --configuration=dev After: ng build --configuration dev This is the first time these build scripts are semantically correct Signed-off-by: ahmedomosanya <[email protected]> * chore: remove unnecessary .npmrc file Signed-off-by: ahmedomosanya <[email protected]> * fix: remove invalid defaultConfiguration from angular.json - Remove 'defaultConfiguration: ""' which causes Angular CLI to fail - Empty string is invalid, Angular CLI expects non-empty configuration name - Base build options already have development-friendly defaults (sourceMap: true, optimization: false) - Angular CLI will use base configuration when no specific configuration is specified Fixes error: 'Configuration "" could not be found for project' Signed-off-by: ahmedomosanya <[email protected]> --------- Signed-off-by: ahmedomosanya <[email protected]>
1 parent 5092222 commit 42aff30

19 files changed

+5745
-5034
lines changed

.github/workflows/build-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Set up Node.js
2525
uses: actions/setup-node@v4
2626
with:
27-
node-version: 16
27+
node-version: 18
2828
cache: yarn
2929
cache-dependency-path: "yarn.lock"
3030

.github/workflows/deploy-dev.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Set up Node.js
2424
uses: actions/setup-node@v4
2525
with:
26-
node-version: 16
26+
node-version: 18
2727
cache: yarn
2828
cache-dependency-path: "yarn.lock"
2929

@@ -60,7 +60,7 @@ jobs:
6060
- name: Set up Node.js
6161
uses: actions/setup-node@v4
6262
with:
63-
node-version: 16
63+
node-version: 18
6464
cache: yarn
6565
cache-dependency-path: "yarn.lock"
6666

.github/workflows/deploy-prod.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Set up Node.js
2727
uses: actions/setup-node@v4
2828
with:
29-
node-version: 16
29+
node-version: 18
3030
cache: yarn
3131
cache-dependency-path: "yarn.lock"
3232

@@ -63,7 +63,7 @@ jobs:
6363
- name: Set up Node.js
6464
uses: actions/setup-node@v4
6565
with:
66-
node-version: 16
66+
node-version: 18
6767
cache: yarn
6868
cache-dependency-path: "yarn.lock"
6969

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Node.js
2222
uses: actions/setup-node@v4
2323
with:
24-
node-version: 16
24+
node-version: 18
2525
cache: yarn
2626
cache-dependency-path: "yarn.lock"
2727

.github/workflows/snyk-scan-edge-npm-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Setup Node
2222
uses: actions/setup-node@v4
2323
with:
24-
node-version: '16'
24+
node-version: '18'
2525
cache: 'yarn'
2626
cache-dependency-path: 'yarn.lock'
2727
- name: Yarn Version

.github/workflows/snyk-scan-npm-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Setup Node
2222
uses: actions/setup-node@v4
2323
with:
24-
node-version: '16'
24+
node-version: '18'
2525
cache: 'yarn'
2626
cache-dependency-path: 'yarn.lock'
2727
- name: Yarn Version

.github/workflows/yarn-scan-cypress-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- name: Setup Node
2121
uses: actions/setup-node@v4
2222
with:
23-
node-version: "16"
23+
node-version: "18"
2424
cache: "yarn"
2525
cache-dependency-path: "test/functional/yarn.lock"
2626

.github/workflows/yarn-scan-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Setup Node
2020
uses: actions/setup-node@v4
2121
with:
22-
node-version: '16'
22+
node-version: '18'
2323
cache: 'yarn'
2424
cache-dependency-path: 'yarn.lock'
2525
- name: Setup

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,3 +73,4 @@ Thumbs.db
7373
.nosync
7474
out
7575
*.swp
76+
.angular/

angular.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,16 @@
2222
"main": "src/main.ts",
2323
"polyfills": "src/polyfills.ts",
2424
"tsConfig": "tsconfig.app.json",
25-
"aot": true,
2625
"assets": ["src/favicon.ico", "src/assets"],
2726
"styles": ["src/styles.scss"],
2827
"scripts": [],
29-
"allowedCommonJsDependencies": ["url-parse", "query-string", "src/app/core/services/cla-contributor.service"]
28+
"allowedCommonJsDependencies": ["url-parse", "query-string", "src/app/core/services/cla-contributor.service", "@linuxfoundation/lfx-ui-core"],
29+
"vendorChunk": true,
30+
"extractLicenses": false,
31+
"buildOptimizer": false,
32+
"sourceMap": true,
33+
"optimization": false,
34+
"namedChunks": true
3035
},
3136
"configurations": {
3237
"production": {

0 commit comments

Comments
 (0)