Merge pull request #161 from amolsontakke3576/bug/gerrit_login_timeout

dealako · web-flow · commit baf5336c3895 · 2020-12-17T08:04:45.000-08:00
diff --git a/src/app/shared/services/auth.service.ts b/src/app/shared/services/auth.service.ts
@@ -121,15 +121,16 @@ export class AuthService {
   }
 
   login() {
-   
-    setTimeout(() => {
+   // Need to increase timeout to 1500 as for slower network it gives an error
+   // Cannot read property 'querySelector' of null
+   setTimeout(() => {
       const button = document
       .querySelector('#lfx-header')
       .shadowRoot.querySelector('.lfx-header.is-login-link') as HTMLElement;
     if (button) {
       button.click();
     }
-    }, 500)
+    }, 1500)
   }
 
   logout() {
diff --git a/src/index.html b/src/index.html
@@ -14,7 +14,7 @@
   <link rel="icon" type="image/x-icon" href="https://cdn.platform.linuxfoundation.org/assets/lf-favicon.png">
 </head>
 <body>
-  <lfx-header product="LF CLA" docslink="https://docs.linuxfoundation.org/docs/v/v2/communitybridge/easycla"
+  <lfx-header product="LF CLA" docslink="https://docs.linuxfoundation.org/lfx/v/v2/easycla"
     supportlink="https://jira.linuxfoundation.org/plugins/servlet/theme/portal/4/create/143" id="lfx-header"
     faqlink="https://docs.linuxfoundation.org/lfx/easycla/getting-started/easycla-faqs">
 </lfx-header>

Original file line number	Diff line number	Diff line change
`@@ -121,15 +121,16 @@ export class AuthService {`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`login() {`
`124`		`-`
`125`		`- setTimeout(() => {`
	`124`	`+ // Need to increase timeout to 1500 as for slower network it gives an error`
	`125`	`+ // Cannot read property 'querySelector' of null`
	`126`	`+ setTimeout(() => {`
`126`	`127`	`const button = document`
`127`	`128`	`.querySelector('#lfx-header')`
`128`	`129`	`.shadowRoot.querySelector('.lfx-header.is-login-link') as HTMLElement;`
`129`	`130`	`if (button) {`
`130`	`131`	`button.click();`
`131`	`132`	`}`
`132`		`- }, 500)`
	`133`	`+ }, 1500)`
`133`	`134`	`}`
`134`	`135`
`135`	`136`	`logout() {`