Merge pull request #4508 from communitybridge/revert-4500-feature/gerrit-redirect

lukaszgryglicki · web-flow · commit 1efc7095f8bf · 2025-01-08T08:38:34.000+01:00
Revert "Bug/Gerrit Return URL"
diff --git a/cla-backend-go/v2/sign/service.go b/cla-backend-go/v2/sign/service.go
@@ -2343,8 +2343,8 @@ func (s *service) RequestIndividualSignatureGerrit(ctx context.Context, input *m
 		return nil, errors.New("no gerrits found for project")
 	}
 
-	returnURL := input.ReturnURL
-	log.WithFields(f).Debugf("returnURL: %s", input.ReturnURL)
+	returnURL := gerrits.List[0].GerritURL
+	log.WithFields(f).Debugf("returnURL: %s", returnURL)
 
 	if latestSignature != nil {
 		log.WithFields(f).Debugf("comparing latest signature document version: %s to latest document version: %s", latestSignature.SignatureDocumentMajorVersion, latestDocument.DocumentMajorVersion)

Original file line number	Diff line number	Diff line change
`@@ -2343,8 +2343,8 @@ func (s service) RequestIndividualSignatureGerrit(ctx context.Context, input m`
`2343`	`2343`	`return nil, errors.New("no gerrits found for project")`
`2344`	`2344`	`}`
`2345`	`2345`
`2346`		`- returnURL := input.ReturnURL`
`2347`		`- log.WithFields(f).Debugf("returnURL: %s", input.ReturnURL)`
	`2346`	`+ returnURL := gerrits.List[0].GerritURL`
	`2347`	`+ log.WithFields(f).Debugf("returnURL: %s", returnURL)`
`2348`	`2348`
`2349`	`2349`	`if latestSignature != nil {`
`2350`	`2350`	`log.WithFields(f).Debugf("comparing latest signature document version: %s to latest document version: %s", latestSignature.SignatureDocumentMajorVersion, latestDocument.DocumentMajorVersion)`