Skip to content

Commit 34e96de

Browse files
Merge branch 'dev' into main
2 parents a37dcc8 + c7eabbe commit 34e96de

File tree

5 files changed

+14
-11
lines changed

5 files changed

+14
-11
lines changed

cla-backend-go/gitlab_api/client.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,9 @@ func EncryptAuthInfo(oauthResp *OauthSuccessResponse, gitLabApp *App) (string, e
6666
if err != nil {
6767
return "", fmt.Errorf("problem marshalling oauth resp json, error: %v", err)
6868
}
69+
if len(b) > 64*1024*1024 { // 64 MB limit
70+
return "", fmt.Errorf("oauth response size too large")
71+
}
6972
authInfo := string(b)
7073
//log.Infof("auth info before encrypting : %s", authInfo)
7174

cla-backend-go/v2/gitlab-activity/service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ func (s *service) checkGitLabGroupApproval(ctx context.Context, userName, URL st
722722

723723
log.WithFields(f).Debugf("checking approval list gitlab org criteria : %s for user: %s ", URL, userName)
724724
var searchURL = URL
725-
params := getParams(`(?P<base>\bhttps://gitlab.com/\b)(?P<group>\bgroups\/\b)?(?P<name>\w+)`, URL)
725+
params := getParams(`(?P<base>\bhttps://gitlab\.com/\b)(?P<group>\bgroups\/\b)?(?P<name>\w+)`, URL)
726726
if params[`group`] == "" {
727727
params[`group`] = "groups/"
728728
updated := fmt.Sprintf("%s%s%s", params[`base`], params[`group`], params[`name`])

cla-backend/cla/utils.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1209,13 +1209,13 @@ def fetch_token(client_id, state, token_url, client_secret, code, redirect_uri=N
12091209
oauth2 = OAuth2Session(client_id, state=state, scope=["user:email"], redirect_uri=redirect_uri)
12101210
else:
12111211
oauth2 = OAuth2Session(client_id, state=state, scope=["user:email"])
1212-
cla.log.debug(
1213-
f"{fn} - oauth2.fetch_token - "
1214-
f"token_url: {token_url}, "
1215-
f"client_id: {client_id}, "
1216-
f"client_secret: {client_secret}, "
1217-
f"code: {code}"
1218-
)
1212+
#cla.log.debug(
1213+
# f"{fn} - oauth2.fetch_token - "
1214+
# f"token_url: {token_url}, "
1215+
# f"client_id: {client_id}, "
1216+
# f"client_secret: {client_secret}, "
1217+
# f"code: {code}"
1218+
#)
12191219
return oauth2.fetch_token(token_url, client_secret=client_secret, code=code)
12201220

12211221

cla-backend/requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ attrs==19.3.0
55
beautifulsoup4==4.8.1
66
boto3==1.22.1
77
botocore==1.25.11
8-
certifi==2023.7.22
8+
certifi==2024.7.4
99
chardet==3.0.4
1010
colorama==0.4.3
1111
coverage==4.5.4
@@ -16,7 +16,6 @@ ecdsa==0.14.1
1616
falcon==2.0.0
1717
future==0.18.3
1818
gossip==2.3.1
19-
gunicorn==19.9.0
2019
hug==2.6.0
2120
idna==3.7
2221
importlib-metadata==1.6.1
@@ -56,3 +55,4 @@ pynamodb==6.0.2
5655
wrapt==1.17.2
5756
astroid==3.3.8
5857
pluggy==1.5.0
58+
gunicorn==22.0.0

tests/rest/requirements.freeze.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ pytest-sugar==0.9.2
2525
pytest-tldr==0.2.1
2626
python-box==3.4.5
2727
python-dateutil==2.8.0
28-
PyYAML==5.1.2
28+
PyYAML==5.3.1
2929
requests==2.22.0
3030
six==1.12.0
3131
stevedore==1.31.0

0 commit comments

Comments
 (0)