Added test suite to test against all dev projects

Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>

Author: lukaszgryglicki

cla-backend-go/cmd/response_metrics.go

@@ -4,6 +4,7 @@
 package cmd
 
 import (
+	"sync"
 	"time"
 
 	"github.com/linuxfoundation/easycla/cla-backend-go/utils"
@@ -18,32 +19,33 @@ type responseMetrics struct {
 	expire  time.Time
 }
 
-var reqMap = make(map[string]*responseMetrics, 5)
+var reqMap sync.Map
 
 // requestStart holds the request ID, method and timing information in a small structure
 func requestStart(reqID, method string) {
 	now, _ := utils.CurrentTime()
-	reqMap[reqID] = &responseMetrics{
+	rm := &responseMetrics{
 		reqID:   reqID,
 		method:  method,
 		start:   now,
 		elapsed: 0,
 		expire:  now.Add(time.Minute * 5),
 	}
+	reqMap.Store(reqID, rm)
 }
 
 // getRequestMetrics returns the response metrics based on the request id value
 func getRequestMetrics(reqID string) *responseMetrics {
-	if x, found := reqMap[reqID]; found {
+	if val, found := reqMap.Load(reqID); found {
+		rm := val.(*responseMetrics)
 		now, _ := utils.CurrentTime()
-		x.elapsed = now.Sub(x.start)
-		return x
+		rm.elapsed = now.Sub(rm.start)
+		return rm
 	}
-
 	return nil
 }
 
 // clearRequestMetrics removes the request from the map
 func clearRequestMetrics(reqID string) {
-	delete(reqMap, reqID)
+	reqMap.Delete(reqID)
 }

tests/py2go/README.md

@@ -15,5 +15,6 @@
 - `` export XACL="$(cat ../../x-acl.secret)" ``.
 - `` make ``.
 - `` DEBUG=1 PROJECT_UUID=88ee12de-122b-4c46-9046-19422054ed8d PY_API_URL=https://api.lfcla.dev.platform.linuxfoundation.org GO_API_URL=https://api-gw.dev.platform.linuxfoundation.org/cla-service make ``.
+- `` MAX_PARALLEL=8 PY_API_URL=https://api.lfcla.dev.platform.linuxfoundation.org go test -v -run '^TestAllProjectsCompatAPI$' ``.
 - To run a specific test case(s): `` DEBUG=1 PROJECT_UUID=88ee12de-122b-4c46-9046-19422054ed8d PY_API_URL=https://api.lfcla.dev.platform.linuxfoundation.org go test -v -run '^TestProjectCompatAPI$' ``.
 - Manually via `cURL`: `` curl -s -XGET http://127.0.0.1:5001/v4/project-compat/01af041c-fa69-4052-a23c-fb8c1d3bef24 | jq . ``.

tests/py2go/api_test.go

@@ -7,6 +7,9 @@ import (
 	"net/http"
 	"os"
 	"sort"
+	"strconv"
+	"strings"
+	"sync"
 	"testing"
 	"time"
 
@@ -20,6 +23,7 @@ var (
 	PY_API_URL           string
 	GO_API_URL           string
 	DEBUG                bool
+	MAX_PARALLEL         int
 	PROJECT_UUID         string
 	ProjectAPIPath       = [3]string{"/v2/project/%s", "/v4/project/%s", "/v4/project-compat/%s"}
 	ProjectAPIKeyMapping = map[string]string{
@@ -88,6 +92,16 @@ func init() {
 	if dbg != "" {
 		DEBUG = true
 	}
+	MAX_PARALLEL = 1
+	par := os.Getenv("MAX_PARALLEL")
+	if par != "" {
+		iPar, err := strconv.Atoi(par)
+		if err != nil {
+			fmt.Printf("MAX_PARALLEL environment value should be integer >= 1\n")
+		} else if iPar > 0 {
+			MAX_PARALLEL = iPar
+		}
+	}
 	PROJECT_UUID = os.Getenv("PROJECT_UUID")
 }
 
@@ -253,23 +267,7 @@ func compareNestedFields(t *testing.T, pyData, goData, keyMapping map[string]int
 	}
 }
 
-func TestProjectCompatAPI(t *testing.T) {
-	projectId := PROJECT_UUID
-	if projectId == "" {
-		projectId = uuid.New().String()
-		putTestItem("projects", "project_id", projectId, "S", map[string]interface{}{
-			"project_name":                         "CNCF",
-			"project_icla_enabled":                 true,
-			"project_ccla_enabled":                 true,
-			"project_ccla_requires_icla_signature": true,
-			"date_created":                         "2022-11-21T10:31:31Z",
-			"date_modified":                        "2023-02-23T13:14:48Z",
-			"foundation_sfid":                      "a09410000182dD2AAI",
-			"version":                              "2",
-		}, DEBUG)
-		defer deleteTestItem("projects", "project_id", projectId, "S", DEBUG)
-	}
-
+func runProjectCompatAPIForProject(t *testing.T, projectId string) {
 	apiURL := PY_API_URL + fmt.Sprintf(ProjectAPIPath[0], projectId)
 	Debugf("Py API call: %s\n", apiURL)
 	oldResp, err := http.Get(apiURL)
@@ -324,6 +322,73 @@ func TestProjectCompatAPI(t *testing.T) {
 	}
 }
 
+func TestProjectCompatAPI(t *testing.T) {
+	projectId := PROJECT_UUID
+	if projectId == "" {
+		projectId = uuid.New().String()
+		putTestItem("projects", "project_id", projectId, "S", map[string]interface{}{
+			"project_name":                         "CNCF",
+			"project_icla_enabled":                 true,
+			"project_ccla_enabled":                 true,
+			"project_ccla_requires_icla_signature": true,
+			"date_created":                         "2022-11-21T10:31:31Z",
+			"date_modified":                        "2023-02-23T13:14:48Z",
+			"foundation_sfid":                      "a09410000182dD2AAI",
+			"version":                              "2",
+		}, DEBUG)
+		defer deleteTestItem("projects", "project_id", projectId, "S", DEBUG)
+	}
+
+	runProjectCompatAPIForProject(t, projectId)
+}
+
+func TestAllProjectsCompatAPI(t *testing.T) {
+	allProjects := getAllPrimaryKeys("projects", "project_id", "S")
+
+	var failedProjects []string
+	var mtx sync.Mutex
+	sem := make(chan struct{}, MAX_PARALLEL)
+	var wg sync.WaitGroup
+
+	for _, projectID := range allProjects {
+		projID, ok := projectID.(string)
+		if !ok {
+			t.Errorf("Expected string project_id, got: %T", projectID)
+			continue
+		}
+
+		wg.Add(1)
+		sem <- struct{}{}
+
+		go func(projID string) {
+			defer wg.Done()
+			defer func() { <-sem }()
+
+			// Use t.Run in a thread-safe wrapper with a dummy parent test
+			t.Run(fmt.Sprintf("ProjectId=%s", projID), func(t *testing.T) {
+				runProjectCompatAPIForProject(t, projID)
+				if t.Failed() {
+					mtx.Lock()
+					failedProjects = append(failedProjects, projID)
+					mtx.Unlock()
+				}
+			})
+		}(projID)
+	}
+
+	wg.Wait()
+
+	if len(failedProjects) > 0 {
+		fmt.Fprintf(os.Stderr, "\nFailed Project IDs (%d):\n%s\n\n",
+			len(failedProjects),
+			strings.Join(failedProjects, "\n"),
+		)
+		t.Fail() // Mark test as failed
+	} else {
+		fmt.Println("\nAll projects passed.")
+	}
+}
+
 func TestProjectAPI(t *testing.T) {
 	if TOKEN == "" || XACL == "" {
 		t.Fatalf("TOKEN and XACL environment variables must be set")

tests/py2go/dynamo.go

@@ -123,3 +123,66 @@ func deleteTestItem(tableName, keyName string, keyValue interface{}, keyType str
 	}
 	Debugf("deleted entry in %s: %s=%s\n", tName, keyName, keyValue)
 }
+
+func getAllPrimaryKeys(tableName, keyName, keyType string) []interface{} {
+	cfg, err := config.LoadDefaultConfig(
+		context.TODO(),
+		config.WithRegion(REGION),
+		config.WithSharedConfigProfile(PROFILE),
+	)
+	if err != nil {
+		log.Fatalf("unable to load SDK config, %v", err)
+	}
+	client := dynamodb.NewFromConfig(cfg)
+
+	tName := "cla-" + STAGE + "-" + tableName
+	Debugf("getting all keys form %s\n", tName)
+	var results []interface{}
+	var lastEvaluatedKey map[string]types.AttributeValue
+
+	for {
+		input := &dynamodb.ScanInput{
+			TableName:            aws.String(tName),
+			ProjectionExpression: aws.String(keyName),
+			ExclusiveStartKey:    lastEvaluatedKey,
+		}
+
+		output, err := client.Scan(context.TODO(), input)
+		if err != nil {
+			log.Fatalf("Scan error on table %s: %v", tName, err)
+		}
+
+		for _, item := range output.Items {
+			attr, ok := item[keyName]
+			if !ok {
+				Debugf("Key %s not found in item: %+v", keyName, item)
+				continue
+			}
+
+			switch keyType {
+			case "S":
+				if v, ok := attr.(*types.AttributeValueMemberS); ok {
+					results = append(results, v.Value)
+				}
+			case "N":
+				if v, ok := attr.(*types.AttributeValueMemberN); ok {
+					results = append(results, v.Value)
+				}
+			case "BOOL":
+				if v, ok := attr.(*types.AttributeValueMemberBOOL); ok {
+					results = append(results, v.Value)
+				}
+			default:
+				log.Fatalf("Unsupported key type: %s", keyType)
+			}
+		}
+
+		if output.LastEvaluatedKey == nil || len(output.LastEvaluatedKey) == 0 {
+			break
+		}
+		lastEvaluatedKey = output.LastEvaluatedKey
+	}
+
+	Debugf("got keys: %+v\n", results)
+	return results
+}