API ported - fix to return null in exact same format as python

Signed-off-by: Lukasz Gryglicki <[email protected]>

Author: lukaszgryglicki

cla-backend-go/swagger/cla.v2.yaml

@@ -2462,6 +2462,7 @@ paths:
           'project_id': <project-id>,
           'repository_id': <repository-id>,
           'pull_request_id': <PR>,
+          *'merge_request_id': <MR> (optional),
           'return_url': <url-where-user-initiated-signature-from>'
         }
         Returns null if the user does not have an active signature.

cla-backend-go/v2/sign/handlers.go

@@ -24,6 +24,8 @@ import (
 	"github.com/linuxfoundation/easycla/cla-backend-go/gen/v2/restapi/operations/sign"
 	"github.com/linuxfoundation/easycla/cla-backend-go/utils"
 	"github.com/linuxfoundation/easycla/cla-backend-go/v2/organization-service/client/organizations"
+
+	"github.com/go-openapi/runtime"
 )
 
 var (
@@ -265,6 +267,13 @@ func Configure(api *operations.EasyclaAPI, service Service, userService users.Se
 			if err != nil {
 				return sign.NewGetUserActiveSignatureBadRequest().WithPayload(errorResponse(reqId, err))
 			}
+			if resp == nil {
+				return middleware.ResponderFunc(func(w http.ResponseWriter, _ runtime.Producer) {
+					w.Header().Set("Content-Type", "application/json")
+					w.WriteHeader(http.StatusOK)
+					_, _ = w.Write([]byte("null"))
+				})
+			}
 			return sign.NewGetUserActiveSignatureOK().WithPayload(resp)
 		})
 

cla-backend-go/v2/sign/service.go

@@ -2852,6 +2852,9 @@ func (s *service) GetUserActiveSignature(ctx context.Context, userID string) (*m
 		log.WithFields(f).WithError(err).Warnf("unable to get active signature meta data for user: %s", userID)
 		return nil, err
 	}
+	if len(activeSignatureMetadata) == 0 {
+		return nil, nil
+	}
 	log.WithFields(f).Debugf("active signature metadata: %+v", activeSignatureMetadata)
 	var (
 		mergeRequestId *string