Address AI feedback

Signed-off-by: Lukasz Gryglicki <[email protected]>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)

Author: lukaszgryglicki

cla-backend-go/company/service.go

@@ -471,7 +471,7 @@ company.You can choose to accept or deny the request.
 </p>
 %s
 %s`,
-		recipientName, companyName, companyName, requestedUserInfo, utils.GetCorporateURL(false),
+		recipientName, companyName, companyName, requestedUserInfo, utils.GetCorporateURL(),
 		utils.GetEmailHelpContent(false), utils.GetEmailSignOffContent())
 
 	err := utils.SendEmail(subject, body, recipients)
@@ -508,7 +508,7 @@ Manager status.
 </p>
 %s
 %s`,
-		recipientName, companyName, companyName, utils.GetCorporateURL(false),
+		recipientName, companyName, companyName, utils.GetCorporateURL(),
 		utils.GetEmailHelpContent(false), utils.GetEmailSignOffContent())
 
 	err := utils.SendEmail(subject, body, recipients)

cla-backend-go/utils/email.go

@@ -99,8 +99,8 @@ func SendEmail(subject string, body string, recipients []string) error {
 	return emailSender.SendEmail(subject, body, recipients)
 }
 
-// GetCorporateURL returns the corporate URL based on the specified flag
-func GetCorporateURL(isV2Project bool) string {
+// GetCorporateURL returns the corporate V2 URL (V1 has been shut down)
+func GetCorporateURL() string {
 	// V1 corporate console has been shut down - always return V2 URL
 	return config.GetConfig().CorporateConsoleV2URL
 }

cla-backend-go/v2/company/handlers.go

@@ -636,17 +636,8 @@ func Configure(api *operations.EasyclaAPI, service Service, projectClaGroupRepo
 			reqID := utils.GetRequestID(params.XREQUESTID)
 			ctx := context.WithValue(context.Background(), utils.XREQUESTID, reqID) // nolint
 
-			corporateLink := ""
-			// Get appropriate corporate link - V1 is no longer supported, redirect to V2
-			if params.Body.Version == "v1" {
-				// V1 corporate console has been shut down - redirect to V2
-				corporateLink = LFXPortalURL
-			} else if params.Body.Version == "v2" {
-				corporateLink = LFXPortalURL
-			} else {
-				// Default to V2 if version is not specified
-				corporateLink = LFXPortalURL
-			}
+			// V1 corporate console has been shut down - always use V2 console
+			corporateLink := LFXPortalURL
 
 			err := service.RequestCompanyAdmin(ctx, params.UserID, params.Body.ClaManagerEmail.String(), params.Body.ClaManagerName, params.Body.ContributorName, params.Body.ContributorEmail.String(), params.Body.ProjectName, params.Body.CompanyName, corporateLink)
 			if err != nil {

cla-backend/cla/models/docusign_models.py

@@ -2481,7 +2481,7 @@ def document_signed_email_content(icla: bool, project: Project, signature: Signa
                     f'signatures/{project.get_project_id()}/'
                     f'{signature.get_signature_reference_id()}/ccla/pdf')
 
-    corporate_url = get_corporate_url(project.get_version())
+    corporate_url = get_corporate_url()
 
     recipient_name = user.get_user_name() or user.get_lf_username() or None
     # some defensive code

cla-backend/cla/utils.py

@@ -1924,11 +1924,11 @@ def get_email_sign_off_content() -> str:
     return "<p>Thanks,</p><p>EasyCLA Support Team</p>"
 
 
-def get_corporate_url(project_version: str) -> str:
+def get_corporate_url() -> str:
     """
-    helper method that returns appropriate corporate link based on EasyCLA version
-    :param project_version: cla_group version(v1|v2) - deprecated, always returns V2
-    :return: V2 corporate console (V1 has been shut down)
+    helper method that returns the corporate V2 console URL
+    V1 corporate console has been shut down - always returns V2
+    :return: V2 corporate console URL
     """
     # V1 corporate console has been shut down - always return V2
     return CORPORATE_V2_BASE