Merge pull request #1366 from prasannamahajan/bugfix/1106-type-assertion-error

Bugfix/1106 type assertion error

Author: prasannamahajan

cla-backend-go/v2/sign/handlers.go

@@ -44,7 +44,7 @@ func Configure(api *operations.EasyclaAPI, service Service) {
 				if err == ErrCCLANotEnabled || err == ErrTemplateNotConfigured {
 					return sign.NewRequestCorporateSignatureBadRequest().WithPayload(errorResponse(err))
 				}
-				if err == err.(*organizations.ListOrgUsrAdminScopesNotFound) {
+				if _, ok := err.(*organizations.ListOrgUsrAdminScopesNotFound); ok {
 					formatErr := errors.New("user role scopes not found for cla-signatory role ")
 					return sign.NewRequestCorporateSignatureNotFound().WithPayload(errorResponse(formatErr))
 				}

cla-backend-go/v2/signatures/handlers.go

@@ -528,6 +528,9 @@ func Configure(api *operations.EasyclaAPI, projectService project.Service, compa
 }
 
 func isUserHaveAccessOfSignedSignaturePDF(authUser *auth.User, signature *v1Models.Signature, companyService company.IService, projectClaGroupRepo projects_cla_groups.Repository) (bool, error) {
+	if authUser.Admin {
+		return true, nil
+	}
 	projects, err := projectClaGroupRepo.GetProjectsIdsForClaGroup(signature.ProjectID)
 	if err != nil {
 		return false, err