Merge pull request #4784 from linuxfoundation/unicron-4762-cypress-apis-test-coverage-5

Add expected failures tests and fix missing required param and wrong SFDCID regexp

Author: lukaszgryglicki

cla-backend-go/swagger/cla.v2.yaml

@@ -351,6 +351,7 @@ paths:
         - $ref: "#/parameters/x-email"
         - name: claGroupInput
           in: body
+          required: true
           schema:
             $ref: '#/definitions/create-cla-group-input'
       responses:
@@ -4637,7 +4638,9 @@ parameters:
     description: the Salesforce ID of the Foundation
     in: query
     type: string
-    pattern: '^[a-zA-Z0-9]{18}|[a-zA-Z0-9]{15}$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+    pattern: '^([0-9A-Za-z]{15}|[0-9A-Za-z]{18})$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+    minLength: 15
+    maxLength: 18
   companyID:
     name: companyID
     description: The internal company ID representing signing entity name instance (EasyCLA)
@@ -4658,18 +4661,18 @@ parameters:
     in: path
     type: string
     required: true
-    pattern: '^[a-zA-Z0-9]{18}|[a-zA-Z0-9]{15}$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
-    minLength: 5
-    maxLength: 255
+    pattern: '^([0-9A-Za-z]{15}|[0-9A-Za-z]{18})$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+    minLength: 15
+    maxLength: 18
   path-projectSFID:
     name: projectSFID
     description: the Salesforce ID of the project
     in: path
     type: string
     required: true
-    pattern: '^[a-zA-Z0-9]{18}|[a-zA-Z0-9]{15}$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
-    minLength: 5
-    maxLength: 255
+    pattern: '^([0-9A-Za-z]{15}|[0-9A-Za-z]{18})$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+    minLength: 15
+    maxLength: 18
   path-userID:
     name: userID
     description: v1 EasyCLA user Admin ID
@@ -4699,7 +4702,9 @@ parameters:
     in: path
     type: string
     required: true
-    pattern: '^[a-zA-Z0-9]{18}|[a-zA-Z0-9]{15}$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+    pattern: '^([0-9A-Za-z]{15}|[0-9A-Za-z]{18})$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+    minLength: 15
+    maxLength: 18
   path-companyName:
     name: companyName
     description: the company name

cla-backend-go/swagger/common/properties/external-id.yaml

@@ -3,4 +3,6 @@
 
 type: string
 example: "00117000015vpjXAAQ"
-pattern: '^[a-zA-Z0-9]{18}|[a-zA-Z0-9]{15}$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+pattern: '^([0-9A-Za-z]{15}|[0-9A-Za-z]{18})$' # see: https://stackoverflow.com/questions/9742913/validating-a-salesforce-id
+minLength: 15
+maxLength: 18