Merge pull request #4800 from linuxfoundation/unicron-4762-cypress-apis-test-coverage-12

Fix the test coverage with Copilot CLI

Author: lukaszgryglicki

tests/functional/cypress/e2e/v4/signatures.cy.ts

@@ -467,7 +467,7 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
       validate_200_Status(response);
       let list = response.body.emailApprovalList;
       if (list != null) {
-        for (let i = 0; i <= list.length; i++) {
+        for (let i = 0; i < list.length; i++) {
           expect(list[i]).to.not.equal(emailApprovalList);
         }
       }
@@ -515,7 +515,7 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
       validate_200_Status(response);
       let list = response.body.githubOrgApprovalList;
       if (list != null) {
-        for (let i = 0; i <= list.length; i++) {
+        for (let i = 0; i < list.length; i++) {
           expect(list[i]).to.not.equal(gitOrgApprovalList);
         }
       }
@@ -538,14 +538,17 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
     }).then((response) => {
       validate_200_Status(response);
       let list = response.body.githubUsernameApprovalList;
-      for (let i = 0; i <= list.length; i++) {
+      let found = false;
+      for (let i = 0; i < list.length; i++) {
         if (list[i] === gitUsernameApprovalList) {
           expect(list[i]).to.eql(gitUsernameApprovalList);
+          found = true;
           break;
-        } else if (i == list.length) {
-          expect(list[i]).to.eql(gitUsernameApprovalList);
         }
       }
+      if (!found) {
+        expect.fail('GitHub Username not found in approval list');
+      }
     });
   });
 
@@ -566,7 +569,7 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
       validate_200_Status(response);
       let list = response.body.githubUsernameApprovalList;
       if (list != null) {
-        for (let i = 0; i <= list.length; i++) {
+        for (let i = 0; i < list.length; i++) {
           expect(list[i]).to.not.equal(gitUsernameApprovalList);
         }
       }
@@ -589,14 +592,17 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
     }).then((response) => {
       validate_200_Status(response);
       let list = response.body.gitlabUsernameApprovalList;
-      for (let i = 0; i <= list.length; i++) {
+      let found = false;
+      for (let i = 0; i < list.length; i++) {
         if (list[i] === gitUsernameApprovalList) {
           expect(list[i]).to.eql(gitUsernameApprovalList);
+          found = true;
           break;
-        } else if (i == list.length) {
-          expect(list[i]).to.eql(gitUsernameApprovalList);
         }
       }
+      if (!found) {
+        expect.fail('GitLab Username not found in approval list');
+      }
     });
   });
 
@@ -617,7 +623,7 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
       validate_200_Status(response);
       let list = response.body.gitlabUsernameApprovalList;
       if (list != null) {
-        for (let i = 0; i <= list.length; i++) {
+        for (let i = 0; i < list.length; i++) {
           expect(list[i]).to.not.equal(gitUsernameApprovalList);
         }
       }
@@ -640,14 +646,17 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
     }).then((response) => {
       validate_200_Status(response);
       let list = response.body.gitlabOrgApprovalList;
-      for (let i = 0; i <= list.length; i++) {
+      let found = false;
+      for (let i = 0; i < list.length; i++) {
         if (list[i] === gitLabOrgApprovalList) {
           expect(list[i]).to.eql(gitLabOrgApprovalList);
+          found = true;
           break;
-        } else if (i == list.length) {
-          expect(list[i]).to.eql(gitLabOrgApprovalList);
         }
       }
+      if (!found) {
+        expect.fail('GitLab Org not found in approval list');
+      }
     });
   });
 
@@ -668,7 +677,7 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
       validate_200_Status(response);
       let list = response.body.gitlabOrgApprovalList;
       if (list != null) {
-        for (let i = 0; i <= list.length; i++) {
+        for (let i = 0; i < list.length; i++) {
           expect(list[i]).to.not.equal(gitLabOrgApprovalList);
         }
       }
@@ -691,14 +700,17 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
     }).then((response) => {
       validate_200_Status(response);
       let list = response.body.domainApprovalList;
-      for (let i = 0; i <= list.length; i++) {
+      let found = false;
+      for (let i = 0; i < list.length; i++) {
         if (list[i] === domainApprovalList) {
           expect(list[i]).to.eql(domainApprovalList);
+          found = true;
           break;
-        } else if (i == list.length) {
-          expect(list[i]).to.eql(domainApprovalList);
         }
       }
+      if (!found) {
+        expect.fail('Domain not found in approval list');
+      }
     });
   });
 
@@ -719,7 +731,7 @@ describe('To Validate & get list of signatures of ClaGroups via API call', funct
       validate_200_Status(response);
       let list = response.body.domainApprovalList;
       if (list != null) {
-        for (let i = 0; i <= list.length; i++) {
+        for (let i = 0; i < list.length; i++) {
           expect(list[i]).to.not.equal(domainApprovalList);
         }
       }