Approved List of Contributors From My Organization in Project EasyCLA page

[pranab-bajpai]

Summary

Any user associated with a company will be taken to this page after they switch to member console, select project from left navigation and EasyCLA from top navigation.

Here is the link to wireframe for the project page for EasyCLA.

Step 4 in PRD
https://confluence.linuxfoundation.org/display/PROD/Project+Dashboard+for+EasyCLA

Approved List of Contributors From My Organization will show the CLAs signed by user's company. The table displays following columns:

Approved List is the emaild or GitHub userid or GitHub Organization or Domain name that is in approved list.
Coverage Type explains the type of approved list in column 1.
Added on i.e. date it was added to approved list.
Manage allows you to edit the approved list or delete it. There is no confirmation dialog box for editing or deleting a contributor. Only users who have CLA Manager permission for this project should be shown this manage option
The information for this table will be provided by EasyCLA API

NOTE :

If the user's company has not got any signed CLAs that fall under this foundation then this table display is empty.
There is no pagination on this table, all the values will be displayed at once

Acceptance Criteria

• Design Changes Required ?--> Not Applicable (N/A)  
• Unit Testing Complete
  • Unit Testing complete for backend API
  • Unit Testing complete for UI
• Functional Testing Complete
  • Functional Testing complete for backend API
  • Functional Testing complete for UI
• Integration Testing Complete
  • Integration Testing complete for backend API and UI
  • Integration Testing complete end to end dev deployment
• Documentation Updated
• Any Open Sev. 1 bug(s)

[dealako]

@nirupamav I have created a few functional tests for this one. We can easily expend this set of tests to be more comprehensive. Please review: https://github.com/communitybridge/easycla/blob/master/cla-backend-go/cmd/functional_tests/signatures/signatures.go#L199 Let's discuss more on Monday.

[nirupamav]

@pranab-bajpai @dealako
Could you please clarify below queries

1. As per the PRD, Name and Added On are listed. But in our response we are not getting name and added on. As per my understanding, the contributor might not be in our user system to fetch from user service. If my understanding is wrong LFX team fetch the data from user service
2. As per PRD, CLA Manager and Non-CLA Manager can view data but only CLA Manager can edit the data.
   I tested it with different roles and observed that except for cla-manager and lf-operations roles, 401 is returned for other roles
3. As per PRD, CLA-Manager who has access to the project of the organization can manage the list. As of now the API returns 401 if the scope is project|Organization and returns data with 200 when role scope is Organization. Does this mean that if the user is CLA Manager for the Organization, he can manage all projects of the organization

[dealako]

For #1 defined above, for now, we won't load the user's name if they are in the email field. We would have to search around for the user's name - not stored in the signature, most-likely not in the EasyCLA user's table, and probably not in the Platform User service. Most of these users will be GH users with no relationship with CommunityBridge other than pass/fail of the EasyCLA gating.

[dealako]

For #2 - will review the permissions. For now, it's locked down to the CLA Manager and admins.

[nirupamav]

As Endpoint needs modification reopening the ticket

[vinod-kadam]

@prasannamahajan what is the latest update on this one? If it is work in progress then please provide the ETA.