Skip to content

Commit d9246c8

Browse files
authored
fix(mailing-lists): align delivery_mode enum values with Groups.io API contract (#1087)
* fix(mailing-lists): align delivery_mode enum values with Groups.io API contract MailingListMemberDeliveryMode values were 'normal'/'digest'/'none' but the upstream Groups.io API expects 'email_delivery_single'/'email_delivery_digest'/ 'email_delivery_none'. Also adds the three remaining API values (SPECIAL, HTML_DIGEST, SUMMARY) for completeness. Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Andres Tobon <andrest2455@gmail.com> * fix(mailing-lists): update stale delivery_mode JSDoc in interface The MailingListMember interface still documented delivery modes as (normal, digest, none). Updated to reference the actual Groups.io API values to match the corrected enum. Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Andres Tobon <andrest2455@gmail.com> --------- Signed-off-by: Andres Tobon <andrest2455@gmail.com>
1 parent 5158e0b commit d9246c8

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

packages/shared/src/enums/mailing-list.enum.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,15 @@ export enum MailingListMemberType {
5151

5252
/**
5353
* Mailing list member delivery mode
54-
* @description How emails are delivered to this member
54+
* @description How emails are delivered to this member (Groups.io API values)
5555
*/
5656
export enum MailingListMemberDeliveryMode {
57-
NORMAL = 'normal',
58-
DIGEST = 'digest',
59-
NONE = 'none',
57+
NORMAL = 'email_delivery_single',
58+
DIGEST = 'email_delivery_digest',
59+
NONE = 'email_delivery_none',
60+
SPECIAL = 'email_delivery_special',
61+
HTML_DIGEST = 'email_delivery_html_digest',
62+
SUMMARY = 'email_delivery_summary',
6063
}
6164

6265
/**

packages/shared/src/interfaces/mailing-list.interface.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ export interface MailingListMember {
243243
job_title?: string;
244244
/** How member was added (committee or direct) */
245245
member_type: MailingListMemberType;
246-
/** Email delivery mode (normal, digest, none) */
246+
/** Email delivery mode (Groups.io API values, e.g. email_delivery_single, email_delivery_digest, email_delivery_none) */
247247
delivery_mode: MailingListMemberDeliveryMode;
248248
/** Moderation status (none, moderator, owner) */
249249
mod_status: MailingListMemberModStatus;

0 commit comments

Comments
 (0)