Skip to content

Commit 87b21a0

Browse files
committed
support not generating heimdall-signer-cert
We are moving to using secrets-manager to create this secret for dev/staging/production environments. Local envs will still generate this via helm. Issue: LFXV2-893 Signed-off-by: Jordan Evans <[email protected]>
1 parent bd26fd4 commit 87b21a0

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

charts/lfx-platform/templates/heimdall/heimdall-signer-cert.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright The Linux Foundation and each contributor to LFX.
22
# SPDX-License-Identifier: MIT
33
---
4-
{{ if .Values.heimdall.enabled -}}
4+
{{ if and .Values.heimdall.enabled .Values.lfx.generateHeimdallSignerCert.enabled -}}
55
{{/*
66
Generate a cert for Heimdall on install of Chart
77
TODO: Create RBAC rule to limit secret access to heimdall Pods
@@ -13,7 +13,7 @@ apiVersion: v1
1313
kind: Secret
1414
type: Opaque
1515
metadata:
16-
name: heimdall-signer-cert
16+
name: {{ .Values.lfx.generateHeimdallSignerCert.name }}
1717
namespace: {{ .Release.Namespace }}
1818
labels:
1919
{{- include "lfx-platform.labels" . | nindent 4 }}

charts/lfx-platform/values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ lfx:
1616
name: heimdall-trust-bundle
1717
configKey: ca-certificates.crt
1818

19+
# Have helm generate the heimdall-signer-cert secret
20+
# Recommended to disable for production values and manage separately.
21+
generateHeimdallSignerCert:
22+
enabled: true
23+
name: heimdall-signer-cert
24+
1925
whoami:
2026
enabled: true
2127

0 commit comments

Comments
 (0)