Address review items

Linting, vulnerabilities, etc.

Signed-off-by: Eric Searcy <[email protected]>

Author: emsearcy

playbooks/projects/recreate_root_project/root.yaml

@@ -31,7 +31,7 @@ recreate_root_project:
         parent_uid: ""
         stage: ""
         {% set created_at = now_z() %}
-        # Wrap in quotes to ensure YAML doesn't intrepret it as a timestamp and
+        # Wrap in quotes to ensure YAML doesn't interpret it as a timestamp and
         # loose our preferred formatting on output.
         created_at: "{{ created_at }}"
         updated_at: "{{ created_at }}"

pyproject.toml

@@ -7,16 +7,17 @@ version = "0.1.0"
 requires-python = "~=3.12.5"
 dependencies = [
     "faker>=37.12.0",
-    "jinja2>=3.1.5",
+    "jinja2>=3.1.6",
     "jmespath>=1.0.1",
     "names-generator>=0.2.0",
     "nats-py>=2.9.0",
     "pydantic>=2.10.5",
     "python-dotenv>=1.0.1",
     "python-lorem>=1.3.0.post3",
     "pyyaml>=6.0.2",
-    "requests>=2.32.3",
+    "requests>=2.32.4",
     "structlog>=24.4.0",
+    "urllib3>=2.5.0",
 ]
 
 [project.scripts]

scripts/mock-heimdall-jwt.sh

@@ -30,11 +30,11 @@ if [ -z "$key_id" ]; then
 fi
 
 pem_temp_dir=$(mktemp -d)
-kubectl get secret/heimdall-signer-cert -n lfx -o json | jq -r '.data["signer.pem"]' | base64 --decode > ${pem_temp_dir}/signer.pem
+kubectl get secret/heimdall-signer-cert -n lfx -o json | jq -r '.data["signer.pem"]' | base64 --decode > "${pem_temp_dir}"/signer.pem
 
 jwt encode \
     --alg PS256 \
-    --kid $key_id \
+    --kid "$key_id" \
     --exp=+300s \
     --nbf +0s \
     --jti "$(uuidgen)" \
@@ -47,6 +47,6 @@ jwt encode \
 
 jwt_result=$?
 
-rm -rf ${pem_temp_dir}
+rm -rf "${pem_temp_dir}"
 
 exit $jwt_result

src/lfx_v2_mockdata/__init__.py

@@ -43,7 +43,7 @@
 import yaml
 from dotenv import load_dotenv
 from faker import Faker
-from jinja2 import Environment, FileSystemLoader
+from jinja2 import Environment, FileSystemLoader, select_autoescape
 from names_generator import generate_name
 from nats.aio.client import Client as NatsClient
 from nats.errors import TimeoutError
@@ -325,6 +325,10 @@ def yaml_render(template_dir, yaml_file):
         # Create an environment restricted to the passed template directory.
         env = Environment(
             loader=FileSystemLoader(searchpath=template_dir),
+            autoescape=select_autoescape(
+                default_for_string=True,
+                default=True,
+            ),
         )
         # Add helper functions to the Jinja2 environment.
         env.globals["environ"] = dict(os.environ)