Commit 437be4e
authored
fix(meetings): handle string recurrence values from v1 meetings (#194)
* fix(meetings): handle string recurrence values from v1 meetings
In v1 meetings, recurrence pattern fields like type, monthly_week, and
monthly_week_day are returned as strings instead of integers. This caused
strict equality comparisons to fail.
Added parseToInt() helper to handle both string and number inputs, and
updated convertToRecurrencePattern() to parse all numeric fields before use.
LFXV2-865
🤖 Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Asitha de Silva <asithade@gmail.com>
* fix(ui): fix height of meeting card non invited v1 meeting
Signed-off-by: Asitha de Silva <asithade@gmail.com>
* fix(meetings): handle string recurrence values from v1 meetings
In v1 meetings, recurrence pattern fields like type, monthly_week, and
monthly_week_day are returned as strings instead of integers. This caused
strict equality comparisons to fail.
Added parseToInt() helper to handle both string and number inputs, and
updated convertToRecurrencePattern() to parse all numeric fields before use.
Also added handling for one-time meetings (end_times=1) to display
"One-time meeting" instead of "Daily, for 1 occurrence".
LFXV2-865
🤖 Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Asitha de Silva <asithade@gmail.com>
* fix(meetings): use explicit undefined checks for monthlyType
Fix monthlyType determination to use explicit undefined checks instead
of truthiness to handle 0 values correctly (0 is a valid day-of-week
value for Sunday).
LFXV2-865
🤖 Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Asitha de Silva <asithade@gmail.com>
---------
Signed-off-by: Asitha de Silva <asithade@gmail.com>1 parent 3e44a7b commit 437be4e
File tree
3 files changed
+48
-6
lines changed- apps/lfx-one/src/app
- modules/meetings/components/meeting-card
3 files changed
+48
-6
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
| 295 | + | |
| 296 | + | |
295 | 297 | | |
296 | 298 | | |
297 | 299 | | |
| |||
Lines changed: 37 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
32 | 41 | | |
33 | 42 | | |
34 | | - | |
35 | | - | |
36 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
37 | 46 | | |
38 | 47 | | |
| 48 | + | |
39 | 49 | | |
40 | | - | |
| 50 | + | |
41 | 51 | | |
42 | | - | |
| 52 | + | |
43 | 53 | | |
44 | 54 | | |
45 | 55 | | |
46 | 56 | | |
47 | 57 | | |
48 | 58 | | |
49 | | - | |
| 59 | + | |
50 | 60 | | |
51 | 61 | | |
52 | 62 | | |
| |||
56 | 66 | | |
57 | 67 | | |
58 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
59 | 75 | | |
60 | 76 | | |
61 | 77 | | |
62 | 78 | | |
63 | 79 | | |
64 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
65 | 96 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
55 | 64 | | |
56 | 65 | | |
57 | 66 | | |
| |||
0 commit comments