Skip to content

Commit 4b83782

Browse files
authored
Merge branch 'main' into agaete/fix-key-collision
2 parents b700bcf + 4e065d8 commit 4b83782

File tree

38 files changed

+738
-355
lines changed

38 files changed

+738
-355
lines changed

CLAUDE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,3 +143,4 @@ Before starting any work or commits:
143143

144144
- Always use sequential thinking mcp for planning before doing any changes
145145
- Always run yarn build to validate that your changes are building too for validation
146+
- Always remember that our JIRA sprint field is customfield_10020. When we create tickets, we need to assign them to the current user and set it to the current sprint.

apps/lfx-one/public/images/lfx-logo.svg

Lines changed: 0 additions & 7 deletions
This file was deleted.
Lines changed: 18 additions & 0 deletions
Loading

apps/lfx-one/src/app/app.component.html

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,4 @@
22
<!-- SPDX-License-Identifier: MIT -->
33
<p-toast />
44

5-
<!-- Header Component -->
6-
<lfx-header></lfx-header>
7-
8-
<div class="top-20">
9-
<router-outlet />
10-
</div>
5+
<router-outlet />

apps/lfx-one/src/app/app.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,12 @@ import { RouterOutlet } from '@angular/router';
77
import { AuthContext } from '@lfx-one/shared/interfaces';
88
import { ToastModule } from 'primeng/toast';
99

10-
import { HeaderComponent } from './shared/components/header/header.component';
1110
import { SegmentService } from './shared/services/segment.service';
1211
import { UserService } from './shared/services/user.service';
1312

1413
@Component({
1514
selector: 'lfx-root',
16-
imports: [RouterOutlet, HeaderComponent, CommonModule, ToastModule],
15+
imports: [RouterOutlet, CommonModule, ToastModule],
1716
templateUrl: './app.component.html',
1817
styleUrl: './app.component.scss',
1918
})

apps/lfx-one/src/app/layouts/main-layout/main-layout.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
<!-- Copyright The Linux Foundation and each contributor to LFX. -->
22
<!-- SPDX-License-Identifier: MIT -->
33

4-
<div class="flex min-h-screen pt-4">
4+
<div class="flex min-h-screen">
55
<!-- Sidebar - Desktop -->
6-
<div class="hidden lg:block w-72 flex-shrink-0 fixed top-[6rem] left-0">
6+
<div class="hidden lg:block w-64 flex-shrink-0 fixed top-0 left-0">
77
<lfx-sidebar [items]="sidebarItems" [footerItems]="sidebarFooterItems" [showProjectSelector]="true"></lfx-sidebar>
88
</div>
99

1010
<!-- Sidebar - Mobile Overlay -->
1111
@if (showMobileSidebar()) {
1212
<div class="lg:hidden fixed inset-0 z-40 bg-black bg-opacity-50" data-testid="mobile-sidebar-overlay" (click)="closeMobileSidebar()">
13-
<div class="absolute top-0 left-0 bottom-0 w-72 bg-white shadow-xl" (click)="$event.stopPropagation()" data-testid="mobile-sidebar">
13+
<div class="absolute top-0 left-0 bottom-0 w-64 bg-white shadow-xl" (click)="$event.stopPropagation()" data-testid="mobile-sidebar">
1414
<div class="flex items-center justify-between p-4 border-b border-gray-200">
1515
<h2 class="text-lg font-semibold text-gray-900">Menu</h2>
1616
<button
@@ -30,7 +30,7 @@ <h2 class="text-lg font-semibold text-gray-900">Menu</h2>
3030
}
3131

3232
<!-- Main Content Area -->
33-
<main class="flex-1 min-w-0 transition-all duration-300 lg:ml-72" data-testid="main-content">
33+
<main class="flex-1 min-w-0 transition-all duration-300 lg:ml-64 px-[21px] md:px-[32px] py-[24px]" data-testid="main-content">
3434
<router-outlet />
3535
<!-- Footer Component -->
3636
<lfx-footer class="py-8"></lfx-footer>

apps/lfx-one/src/app/layouts/main-layout/main-layout.component.ts

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -25,39 +25,27 @@ export class MainLayoutComponent {
2525
// Expose mobile sidebar state from service
2626
protected readonly showMobileSidebar = this.appService.showMobileSidebar;
2727

28-
// Sidebar navigation items
28+
// Sidebar navigation items - matching React NavigationSidebar design
2929
protected readonly sidebarItems: SidebarMenuItem[] = [
3030
{
31-
label: 'Home',
32-
icon: 'fa-light fa-house',
31+
label: 'Overview',
32+
icon: 'fa-light fa-grid-2',
3333
routerLink: '/',
3434
},
3535
{
3636
label: 'Meetings',
37-
icon: 'fa-light fa-video',
37+
icon: 'fa-light fa-calendar',
3838
routerLink: '/meetings',
3939
},
40+
{
41+
label: 'Projects',
42+
icon: 'fa-light fa-folder-open',
43+
routerLink: '/projects',
44+
},
4045
];
4146

42-
// Sidebar footer items
47+
// Sidebar footer items - matching React NavigationSidebar design
4348
protected readonly sidebarFooterItems: SidebarMenuItem[] = [
44-
{
45-
label: 'Documentation',
46-
icon: 'fa-light fa-file-lines',
47-
url: 'https://docs.lfx.linuxfoundation.org',
48-
disabled: true,
49-
},
50-
{
51-
label: 'Submit a Ticket',
52-
icon: 'fa-light fa-circle-question',
53-
url: 'https://jira.linuxfoundation.org/plugins/servlet/theme/portal/4',
54-
},
55-
{
56-
label: 'Changelog',
57-
icon: 'fa-light fa-rectangle-history',
58-
routerLink: '/changelog',
59-
disabled: true,
60-
},
6149
{
6250
label: 'Settings',
6351
icon: 'fa-light fa-gear',

apps/lfx-one/src/app/layouts/profile-layout/profile-layout.component.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
<!-- Copyright The Linux Foundation and each contributor to LFX. -->
22
<!-- SPDX-License-Identifier: MIT -->
33

4+
<!-- Header Component -->
5+
<lfx-header></lfx-header>
6+
47
<div class="bg-white border-b border-gray-100 py-6 shadow-sm">
58
<div class="container mx-auto px-8">
69
<!-- Breadcrumb Navigation -->

apps/lfx-one/src/app/layouts/profile-layout/profile-layout.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { CombinedProfile } from '@lfx-one/shared/interfaces';
99
import { UserService } from '@services/user.service';
1010
import { AvatarComponent } from '@shared/components/avatar/avatar.component';
1111
import { BreadcrumbComponent } from '@shared/components/breadcrumb/breadcrumb.component';
12+
import { HeaderComponent } from '@shared/components/header/header.component';
1213
import { MenuItem } from 'primeng/api';
1314
import { ChipModule } from 'primeng/chip';
1415
import { finalize } from 'rxjs';
@@ -18,7 +19,7 @@ import { ProfileStatsComponent } from './components/profile-stats/profile-stats.
1819
@Component({
1920
selector: 'lfx-profile-layout',
2021
standalone: true,
21-
imports: [CommonModule, RouterModule, AvatarComponent, BreadcrumbComponent, ChipModule, ProfileStatsComponent],
22+
imports: [CommonModule, RouterModule, HeaderComponent, AvatarComponent, BreadcrumbComponent, ChipModule, ProfileStatsComponent],
2223
templateUrl: './profile-layout.component.html',
2324
styleUrl: './profile-layout.component.scss',
2425
})

apps/lfx-one/src/app/layouts/project-layout/project-layout.component.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
<!-- Copyright The Linux Foundation and each contributor to LFX. -->
22
<!-- SPDX-License-Identifier: MIT -->
33

4+
<!-- Header Component -->
5+
<lfx-header></lfx-header>
6+
47
<div class="bg-white border-b border-gray-100 py-6 shadow-sm min-h-60">
58
<div class="container mx-auto px-8">
69
<!-- Breadcrumb Navigation -->

0 commit comments

Comments
 (0)