Skip to content

Commit a9b525d

Browse files
authored
feat(dev-tools): add development tools and workflow improvements (#40)
* chore(LFXV2-242): update dependencies and fix SSR hydration issues - Update Angular dependencies from 19.2.0 to 19.2.14/19.2.15 - Update PrimeNG from 19.1.3 to 19.1.4 - Update FullCalendar from 6.1.18 to 6.1.19 - Update TypeScript ESLint packages from 8.37.0 to 8.39.1 - Update various other dev dependencies - Add ngSkipHydration to BreadcrumbComponent and HeaderComponent to fix SSR hydration issues - Update CLAUDE.md to require JIRA ticket association for commits 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <asithade@gmail.com> * feat(LFXV2-246): add GitHub Action workflow for PR title linting Add automated PR title validation using reusable workflow from linuxfoundation/lfx-ui. The workflow triggers on PR opened, edited, reopened, and synchronize events. Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <asithade@gmail.com> * feat(dev-tools): add commitlint with Angular conventions - Install @commitlint/cli and @commitlint/config-angular packages - Create commitlint.config.js extending Angular commit conventions - Add commit-msg Husky hook to validate commit messages automatically - Add commitlint script to package.json for manual validation - Update CLAUDE.md with proper commit message convention and branch naming This enforces Angular commit types (feat, fix, docs, etc.) with lowercase scopes and integrates with existing pre-commit workflow. Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <asithade@gmail.com> * ci(dev-infra): update pr title lint workflow configuration - refine workflow configuration for better pr title validation - ensure proper conventional commit format enforcement Signed-off-by: Asitha de Silva <asithade@gmail.com> * revert: remove pr title lint workflow - remove changes from PR #39 to isolate this PR's changes - workflow will be handled separately in its own PR Signed-off-by: Asitha de Silva <asithade@gmail.com> * feat(dev-tools): update package.json configuration - refine package configuration for commitlint setup - ensure proper development tooling integration Signed-off-by: Asitha de Silva <asithade@gmail.com> * docs(claude): update PR title and scope guidelines Signed-off-by: Asitha de Silva <asithade@gmail.com> * docs(project): update commit message guidelines in CLAUDE.md LFXV2-247 Signed-off-by: Asitha de Silva <asithade@gmail.com> --------- Signed-off-by: Asitha de Silva <asithade@gmail.com>
1 parent dcc4403 commit a9b525d

File tree

5 files changed

+479
-7
lines changed

5 files changed

+479
-7
lines changed

.husky/commit-msg

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
yarn commitlint --edit $1

CLAUDE.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,5 +112,13 @@ lfx-pcc-v3/
112112
- **Use data-testid naming convention** - `[section]-[component]-[element]` for hierarchical structure
113113
- **Test responsive behavior** - validate mobile, tablet, and desktop viewports appropriately
114114
- When running tests to validate UI tests, use reporter=list
115-
115+
- Follow Angular commit conventions: `type(scope): description`
116+
- Valid types: feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert
117+
- Scope should be lowercase and describe the affected area (e.g., auth, ui, api, docs) and follow the angular scope conventions
118+
- Use present tense, imperative mood: "add feature" not "added feature"
119+
- Examples:
120+
- `feat(auth): add OAuth2 integration`
121+
- `fix(ui): resolve mobile button alignment`
116122
- All commits and pull requests need to be associated to a JIRA ticket. If there isn't one, we need to create it and reference it moving forward.
123+
- Branch names should be following the commit types (feat,fix,docs, etc) followed by the JIRA ticket number. i.e; feat/LFXV2-123 or ci/LFXV2-456
124+
- PR titles must also follow a similar format as conventional commits - `type(scope): description`. The scope has to follow the angular config for conventional commit and not include the JIRA ticket in the title.

commitlint.config.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export default { extends: ["@commitlint/config-angular"] };

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,12 @@
2222
"format:check": "prettier --check \"**/*.{ts,tsx,js,jsx,html,css,scss,md,mdx,json}\"",
2323
"lint:check": "turbo run lint:check",
2424
"check-types": "turbo run check-types",
25+
"commitlint": "commitlint",
2526
"prepare": "husky"
2627
},
2728
"devDependencies": {
29+
"@commitlint/cli": "^19.8.1",
30+
"@commitlint/config-angular": "^19.8.1",
2831
"@linuxfoundation/lfx-ui-core": "^0.0.20",
2932
"@types/node": "^24.2.1",
3033
"@typescript-eslint/eslint-plugin": "^8.39.1",

0 commit comments

Comments
 (0)