From 57048abb5769d2c9390de1186175cd33a26c8699 Mon Sep 17 00:00:00 2001
From: Asitha de Silva <asithade@gmail.com>
Date: Tue, 18 Nov 2025 15:40:09 -0800
Subject: [PATCH] refactor(meetings): simplify header and fix past meeting
 access checks

LFXV2-763

- Simplified header component by removing search, persona selector, and user profile display
- Added header component to meeting join page for consistent navigation
- Added type safety to getMeetings() method with 'meeting' | 'past_meeting' union type
- Fixed access check service to properly handle past meeting resource type
- Added 'past_meeting' to AccessCheckResourceType in shared interfaces

Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Asitha de Silva <asithade@gmail.com>
---
 .../meeting-join/meeting-join.component.html  |  1 +
 .../meeting-join/meeting-join.component.ts    |  2 +
 .../components/header/header.component.html   | 79 +------------------
 .../src/server/services/meeting.service.ts    |  9 ++-
 .../src/interfaces/access-check.interface.ts  |  2 +-
 5 files changed, 12 insertions(+), 81 deletions(-)

diff --git a/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html b/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html
index af2e76d9..278ceea9 100644
--- a/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html
+++ b/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.html
@@ -1,5 +1,6 @@
 <!-- Copyright The Linux Foundation and each contributor to LFX. -->
 <!-- SPDX-License-Identifier: MIT -->
+<lfx-header></lfx-header>
 
 @if (meeting()) {
   <div class="bg-gray-50 min-h-screen">
diff --git a/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts b/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts
index df0047c1..24dc3006 100644
--- a/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts
+++ b/apps/lfx-one/src/app/modules/meetings/meeting-join/meeting-join.component.ts
@@ -8,6 +8,7 @@ import { Component, computed, inject, signal, Signal, WritableSignal } from '@an
 import { toObservable, toSignal } from '@angular/core/rxjs-interop';
 import { FormControl, FormGroup, ReactiveFormsModule, Validators } from '@angular/forms';
 import { ActivatedRoute, Router } from '@angular/router';
+import { HeaderComponent } from '@app/shared/components/header/header.component';
 import { LinkifyPipe } from '@app/shared/pipes/linkify.pipe';
 import { RecurrenceSummaryPipe } from '@app/shared/pipes/recurrence-summary.pipe';
 import { ButtonComponent } from '@components/button/button.component';
@@ -48,6 +49,7 @@ import { catchError, combineLatest, debounceTime, filter, map, Observable, of, s
     LinkifyPipe,
     FileTypeIconPipe,
     ExpandableTextComponent,
+    HeaderComponent,
   ],
   providers: [],
   templateUrl: './meeting-join.component.html',
diff --git a/apps/lfx-one/src/app/shared/components/header/header.component.html b/apps/lfx-one/src/app/shared/components/header/header.component.html
index 723ca2fd..6e52d6eb 100644
--- a/apps/lfx-one/src/app/shared/components/header/header.component.html
+++ b/apps/lfx-one/src/app/shared/components/header/header.component.html
@@ -2,7 +2,7 @@
 <!-- SPDX-License-Identifier: MIT -->
 
 <div class="sticky top-0 z-50 bg-white border-b border-gray-100">
-  <div class="mx-auto">
+  <div class="mx-auto max-w-6xl">
     <lfx-menubar styleClass="border-none">
       <ng-template #start>
         <div class="flex items-center lg:gap-32">
@@ -19,31 +19,11 @@
           <button type="button" class="flex items-center space-x-2 hover:opacity-80 transition-opacity p-2" routerLink="/" aria-label="Go to home page">
             <img src="/images/lfx-one-logo.svg" alt="LFX Logo" class="w-auto h-5" />
           </button>
-
-          @if (userService.authenticated()) {
-            <div class="items-center gap-3 hidden lg:flex">
-              <lfx-avatar
-                [label]="initials()"
-                [size]="'large'"
-                [shape]="'circle'"
-                styleClass="bg-blue-50 border border-gray-200"
-                [ariaLabel]="fullName() + ' avatar'">
-              </lfx-avatar>
-
-              <div class="flex flex-col gap-1">
-                <span class="text-sm font-semibold">{{ userProfile()?.user?.first_name }} {{ userProfile()?.user?.last_name }}</span>
-                <span class="text-xs text-gray-500"
-                  >{{ userProfile()?.profile?.job_title }} at <span class="text-primary">{{ userProfile()?.profile?.organization }}</span></span
-                >
-              </div>
-            </div>
-          }
         </div>
       </ng-template>
 
       <ng-template #end>
         <div class="flex items-center gap-4">
-          <lfx-persona-selector></lfx-persona-selector>
           <div class="flex items-center gap-6">
             <!-- Mobile Search Toggle -->
             <button
@@ -58,24 +38,6 @@
             <!-- Search Input -->
             <div>
               <div class="relative flex items-center gap-4">
-                <div class="items-center gap-2 hidden md:flex">
-                  <lfx-autocomplete
-                    [form]="searchForm"
-                    control="search"
-                    [suggestions]="suggestions()"
-                    optionLabel="name"
-                    placeholder="Search projects..."
-                    styleClass="w-80"
-                    inputStyleClass="pl-10 pr-4 py-2 bg-gray-50 border border-gray-200 rounded-full focus:outline-none focus:ring-1 focus:ring-blue-500 focus:border-blue-500 focus:bg-white text-sm placeholder-gray-400 transition-all w-full"
-                    panelStyleClass="mt-2 max-w-[280px]"
-                    dataTestId="header-search-autocomplete"
-                    (completeMethod)="onSearchComplete($event)"
-                    (onSelect)="onProjectSelect($event)"
-                    (onClear)="onSearchClear()"
-                    [autoHighlight]="true">
-                  </lfx-autocomplete>
-                  <i class="fa-light fa-magnifying-glass absolute left-3 top-1/2 transform -translate-y-1/2 text-gray-400 text-sm pointer-events-none"></i>
-                </div>
                 @if (userService.authenticated()) {
                   <div class="flex items-center gap-4">
                     <lfx-avatar
@@ -97,43 +59,4 @@
       </ng-template>
     </lfx-menubar>
   </div>
-
-  <!-- Mobile Search Drawer -->
-  @if (showMobileSearch()) {
-    <div class="md:hidden fixed inset-0 z-50 bg-black bg-opacity-50" data-testid="mobile-search-overlay" (click)="closeMobileSearch()">
-      <div class="absolute top-0 left-0 right-0 bg-white shadow-lg" (click)="$event.stopPropagation()">
-        <div class="container mx-auto p-4">
-          <div class="flex items-center gap-4">
-            <button
-              type="button"
-              class="hover:opacity-80 transition-opacity p-2"
-              (click)="closeMobileSearch()"
-              aria-label="Close search"
-              data-testid="mobile-search-close">
-              <i class="fa-light fa-times text-gray-600"></i>
-            </button>
-            <div class="flex-1 relative">
-              <lfx-autocomplete
-                #mobileSearchInput
-                [form]="searchForm"
-                control="search"
-                [suggestions]="suggestions()"
-                optionLabel="name"
-                placeholder="Search projects..."
-                styleClass="w-full"
-                inputStyleClass="pl-10 pr-4 py-2 bg-gray-50 border border-gray-200 rounded-full focus:outline-none focus:ring-1 focus:ring-blue-500 focus:border-blue-500 focus:bg-white text-sm placeholder-gray-400 transition-all w-full"
-                panelStyleClass="mt-2"
-                dataTestId="mobile-search-autocomplete"
-                (completeMethod)="onSearchComplete($event)"
-                (onSelect)="onProjectSelect($event)"
-                (onClear)="onSearchClear()"
-                [autoHighlight]="true">
-              </lfx-autocomplete>
-              <i class="fa-light fa-magnifying-glass absolute left-3 top-1/2 transform -translate-y-1/2 text-gray-400 text-sm pointer-events-none"></i>
-            </div>
-          </div>
-        </div>
-      </div>
-    </div>
-  }
 </div>
diff --git a/apps/lfx-one/src/server/services/meeting.service.ts b/apps/lfx-one/src/server/services/meeting.service.ts
index 23315923..475609f5 100644
--- a/apps/lfx-one/src/server/services/meeting.service.ts
+++ b/apps/lfx-one/src/server/services/meeting.service.ts
@@ -51,7 +51,12 @@ export class MeetingService {
   /**
    * Fetches all meetings based on query parameters
    */
-  public async getMeetings(req: Request, query: Record<string, any> = {}, meetingType: string = 'meeting', access: boolean = true): Promise<Meeting[]> {
+  public async getMeetings(
+    req: Request,
+    query: Record<string, any> = {},
+    meetingType: 'meeting' | 'past_meeting' = 'meeting',
+    access: boolean = true
+  ): Promise<Meeting[]> {
     const params = {
       ...query,
       type: meetingType,
@@ -71,7 +76,7 @@ export class MeetingService {
 
     if (access) {
       // Add writer access field to all meetings
-      return await this.accessCheckService.addAccessToResources(req, meetings, 'meeting', 'organizer');
+      return await this.accessCheckService.addAccessToResources(req, meetings, meetingType, 'organizer');
     }
 
     return meetings;
diff --git a/packages/shared/src/interfaces/access-check.interface.ts b/packages/shared/src/interfaces/access-check.interface.ts
index f0161712..747d2561 100644
--- a/packages/shared/src/interfaces/access-check.interface.ts
+++ b/packages/shared/src/interfaces/access-check.interface.ts
@@ -32,5 +32,5 @@ export interface AccessCheckApiResponse {
 /**
  * Resource types
  */
-export type AccessCheckResourceType = 'project' | 'meeting' | 'committee';
+export type AccessCheckResourceType = 'project' | 'meeting' | 'committee' | 'past_meeting';
 export type AccessCheckAccessType = 'writer' | 'viewer' | 'organizer';