Plus de tests, les contrôleurs sont testés à plus de 99%

Il manque les contrôleurs d'API dans cette couverture...

Author: echarp

test/controllers/bookmarks_controller_test.rb

@@ -15,14 +15,19 @@ class BookmarksControllerTest < ActionDispatch::IntegrationTest
     assert_nil flash[:alert]
   end
 
+  test 'should not find bookmark' do
+    get user_bookmark_url(users('visitor_1'), bookmarks(:one), format: :html)
+    assert_redirected_to user_bookmark_url(users('visitor_0'), Bookmark.last)
+  end
+
   test 'should get new' do
-    sign_in accounts 'maintainer_0'
+    sign_in accounts 'visitor_0'
     get new_bookmark_url
     assert_response :success
   end
 
   test 'should preview bookmark' do
-    sign_in accounts 'maintainer_0'
+    sign_in accounts 'visitor_0'
     assert_no_difference('Bookmark.count') do
       post bookmarks_url,
            params: {
@@ -38,7 +43,7 @@ class BookmarksControllerTest < ActionDispatch::IntegrationTest
   end
 
   test 'should create bookmark' do
-    sign_in accounts 'maintainer_0'
+    sign_in accounts 'visitor_0'
     assert_difference('Bookmark.count') do
       post bookmarks_url,
            params: {
@@ -50,7 +55,7 @@ class BookmarksControllerTest < ActionDispatch::IntegrationTest
              tags: 'foo, bar'
            }
     end
-    assert_redirected_to user_bookmark_url(users('maintainer_0'), Bookmark.last)
+    assert_redirected_to user_bookmark_url(users('visitor_0'), Bookmark.last)
   end
 
   test 'should get edit' do
@@ -59,6 +64,18 @@ class BookmarksControllerTest < ActionDispatch::IntegrationTest
     assert_response :success
   end
 
+  test 'should preview update' do
+    sign_in accounts 'admin_0'
+    patch user_bookmark_url(users('visitor_0'), bookmarks(:one)),
+          params: {
+            bookmark: {
+              link: 'http://example.com'
+            },
+            commit: 'Prévisualiser'
+          }
+    assert_response :success
+  end
+
   test 'should update bookmark' do
     sign_in accounts 'admin_0'
     patch user_bookmark_url(users('visitor_0'), bookmarks(:one)),
@@ -70,6 +87,17 @@ class BookmarksControllerTest < ActionDispatch::IntegrationTest
     assert_redirected_to user_bookmark_url(users('visitor_0'), bookmarks(:one))
   end
 
+  test 'should not update bookmark' do
+    sign_in accounts 'admin_0'
+    patch user_bookmark_url(users('visitor_0'), bookmarks(:one)),
+          params: {
+            bookmark: {
+              title: ''
+            }
+          }
+    assert_response :success
+  end
+
   test 'should destroy bookmark' do
     sign_in accounts 'admin_0'
     delete user_bookmark_url(users('visitor_0'), bookmarks(:one))

test/controllers/home_controller_test.rb

@@ -9,6 +9,10 @@ class HomeControllerTest < ActionDispatch::IntegrationTest
 
     get root_url
     assert_response :success
+
+    assert_select 'title', 'Accueil - LinuxFr.org'
+
+    post destroy_account_session_url
   end
 
   test 'should not login' do

test/controllers/moderation/news_controller_test.rb

@@ -57,8 +57,21 @@ class Moderation::NewsControllerTest < ActionDispatch::IntegrationTest
     assert_redirected_to moderation_news_url news(:candidate)
   end
 
+  test 'should not accept empty news' do
+    sign_in accounts 'admin_0'
+
+    news(:first_part_only).paragraphs << Paragraph.new(wiki_body: News::DEFAULT_PARAGRAPH)
+
+    assert_no_difference 'News.candidate.count' do
+      post accept_moderation_news_url news(:first_part_only)
+      assert flash[:alert]
+    end
+    assert_redirected_to moderation_news_url news(:first_part_only)
+  end
+
   test 'should accept news' do
     sign_in accounts 'admin_0'
+
     assert_difference 'News.candidate.count', -1 do
       post accept_moderation_news_url news(:candidate)
       assert flash[:alert]

test/controllers/moderation/polls_controller_test.rb

@@ -1,8 +1,74 @@
 require 'test_helper'
 
 class Moderation::PollControllerTest < ActionDispatch::IntegrationTest
-  # Replace this with your real tests.
-  test 'the truth' do
-    assert true
+  include Devise::Test::IntegrationHelpers
+
+  setup do
+    sign_in accounts 'moderator_0'
+  end
+
+  test 'should list polls' do
+    get moderation_polls_url
+    assert_response :success
+  end
+
+  test 'should show poll' do
+    comments(:poll_2).parent_id = comments(:poll).id
+    comments(:poll_2).generate_materialized_path
+    get moderation_poll_url(polls(:one))
+    assert_response :success
+  end
+
+  test 'should accept poll' do
+    # For information, there can only be one published poll!
+    assert_difference('Poll.draft.count', -1) do
+      post accept_moderation_poll_url(polls(:draft))
+      assert_nil flash[:alert]
+      assert flash[:notice]
+    end
+    assert_redirected_to poll_url polls(:draft)
+  end
+
+  test 'should refuse poll' do
+    assert_difference('Poll.draft.count', -1) do
+      post refuse_moderation_poll_url(polls(:draft))
+      assert_nil flash[:alert]
+      assert flash[:notice]
+    end
+    assert_redirected_to moderation_polls_url
+  end
+
+  test 'should get edit' do
+    get edit_moderation_poll_url(polls(:one))
+    assert_response :success
+  end
+
+  test 'should update poll' do
+    patch moderation_poll_url(polls(:one)), params: {
+      poll: {
+        title: 'hello world my poll'
+      }
+    }
+    assert_nil flash[:alert]
+    assert flash[:notice]
+    assert_redirected_to moderation_poll_url(polls(:one).reload)
+  end
+
+  test 'should not update poll' do
+    patch moderation_poll_url(polls(:one)), params: {
+      poll: {
+        title: ''
+      }
+    }
+    assert flash[:alert]
+    assert_nil flash[:notice]
+    assert_response :success
+  end
+
+  test 'should set poll on ppp' do
+    post ppp_moderation_poll_url(polls(:one))
+    assert_nil flash[:alert]
+    assert flash[:notice]
+    assert_redirected_to root_url
   end
 end

test/controllers/moderation/tags_controller_test.rb

@@ -0,0 +1,14 @@
+require 'test_helper'
+
+class Moderation::TagsControllerTest < ActionDispatch::IntegrationTest
+  include Devise::Test::IntegrationHelpers
+
+  setup do
+    sign_in accounts 'moderator_0'
+  end
+
+  test 'should list tags' do
+    get moderation_tags_url
+    assert_response :success
+  end
+end

test/controllers/posts_controller_test.rb

@@ -13,6 +13,17 @@ class PostsControllerTest < ActionDispatch::IntegrationTest
     assert_response :success
   end
 
+  test 'should show post when logged in' do
+    sign_in accounts 'visitor_0'
+    get forum_post_url(forums(:one), posts(:one))
+    assert_response :success
+  end
+
+  test 'should show post from another forum' do
+    get forum_post_url(forums(:two), posts(:one))
+    assert_redirected_to forum_post_url forums(:one), posts(:one)
+  end
+
   test 'should get new page' do
     sign_in accounts 'maintainer_0'
     get new_post_url forums(:one)

test/controllers/redaction/links_controller_test.rb

@@ -32,11 +32,34 @@ def setup
     assert_response :success
   end
 
+  test 'should not create link' do
+    assert_no_difference 'Link.count' do
+      post redaction_links_url params: {
+        link: {
+          lang: 'fr',
+          url: 'https://linuxfr.org'
+        },
+        news_id: news(:news).id
+      }
+    end
+    assert_response :unprocessable_entity
+  end
+
   test 'should get edit' do
     get edit_redaction_link_url links(:one)
     assert_response :success
   end
 
+  test 'should not get edit' do
+    get edit_redaction_link_url links(:one)
+
+    sign_in accounts 'moderator_0'
+    get edit_redaction_link_url links(:one)
+    assert_response :forbidden
+
+    post unlock_redaction_link_url links(:one)
+  end
+
   test 'should update link' do
     patch redaction_link_url links(:one), params: {
       link: {
@@ -48,6 +71,17 @@ def setup
     assert_response :success
   end
 
+  test 'should not update link' do
+    patch redaction_link_url links(:one), params: {
+      link: {
+        lang: 'fr',
+        title: '',
+        url: 'https://linuxfr.org'
+      }
+    }
+    assert_response :unprocessable_entity
+  end
+
   test 'should unlock link' do
     post unlock_redaction_link_url links(:one)
     assert_response :no_content

test/controllers/redaction/news_controller_test.rb

@@ -70,10 +70,13 @@ class Redaction::NewsControllerTest < ActionDispatch::IntegrationTest
   end
 
   test 'should get reorganize news page' do
-    sign_in accounts 'admin_0'
     get reorganize_redaction_news_url news(:draft)
     assert_nil flash[:alert]
     assert_response :success
+
+    sign_in accounts 'visitor_1'
+    get reorganize_redaction_news_url news(:draft)
+    assert_response :forbidden
   end
 
   test 'should reorganize news' do
@@ -83,7 +86,16 @@ class Redaction::NewsControllerTest < ActionDispatch::IntegrationTest
       }
     }
     assert_nil flash[:alert]
-    assert_redirected_to redaction_news_url News.draft.last
+    assert_redirected_to redaction_news_url news(:draft).reload
+  end
+
+  test 'should not reorganize news' do
+    put reorganized_redaction_news_url news(:draft), params: {
+      news: {
+        title: ''
+      }
+    }
+    assert_response :success
   end
 
   test 'should get revision' do
@@ -105,7 +117,7 @@ class Redaction::NewsControllerTest < ActionDispatch::IntegrationTest
       message: 'Hello world'
     }
     assert_nil flash[:alert]
-    assert_redirected_to redaction_news_url News.draft.last
+    assert_redirected_to redaction_news_url news(:draft).reload
   end
 
   test 'should submit news' do
@@ -123,6 +135,15 @@ class Redaction::NewsControllerTest < ActionDispatch::IntegrationTest
     assert_redirected_to redaction_url
   end
 
+  test 'should not submit news' do
+    # To lock the news
+    get reorganize_redaction_news_url news(:draft)
+
+    post submit_redaction_news_url news(:draft).id
+    assert flash[:alert]
+    assert_redirected_to redaction_news_url news(:draft)
+  end
+
   test 'should erase news' do
     sign_in accounts 'admin_0'
     assert_difference('News.draft.count', -1) do

test/controllers/redaction/paragraphs_controller_test.rb

@@ -25,6 +25,15 @@ class Moderation::ParagraphsControllerTest < ActionDispatch::IntegrationTest
     end
 
     assert_response :created
+
+    assert_difference 'Paragraph.count' do
+      post redaction_news_paragraphs_url news(:first_part_only)
+      assert_nil flash[:alert]
+      assert_equal 1, news(:first_part_only).paragraphs.in_first_part.count
+      assert_equal 0, news(:first_part_only).paragraphs.in_second_part.count
+    end
+
+    assert_response :created
   end
 
   test 'should show paragraph' do
@@ -35,6 +44,10 @@ class Moderation::ParagraphsControllerTest < ActionDispatch::IntegrationTest
   test 'should edit paragraph' do
     get edit_redaction_paragraph_url paragraphs(:one)
     assert_response :success
+
+    sign_in accounts 'moderator_1'
+    get edit_redaction_paragraph_url paragraphs(:one)
+    assert_response :forbidden
   end
 
   test 'should update paragraph' do

test/controllers/static_controller_test.rb

@@ -6,6 +6,30 @@ class StaticControllerTest < ActionDispatch::IntegrationTest
     assert_response :success
   end
 
+  test 'should get equipe page' do
+    pages(:equipe).body = File.read('db/pages/equipe.html')
+    pages(:equipe).save!
+
+    get static_url pages(:equipe)
+    assert_response :success
+  end
+
+  test 'should get sites amis' do
+    pages(:amis).body = File.read('db/pages/sites-amis.html')
+    pages(:amis).save!
+
+    get static_url pages(:amis)
+    assert_response :success
+  end
+
+  test 'should get règles de modération' do
+    pages(:moderation).body = File.read('db/pages/regles_de_moderation.html')
+    pages(:moderation).save!
+
+    get static_url pages(:moderation)
+    assert_response :success
+  end
+
   test 'get changelog' do
     get changelog_url pages(:one)
     assert_response :success