Skip to content

Commit 6b6c352

Browse files
committed
RonRonnement CSS: Fix small discontinuity in the left sidebar
Commit 88aa3c3 included a small computation mistake: the border should be taken into account in the calculations. Also, while it looks correct in Chrome, for some reason Firefox does not properly position the linear gradient origin when the background is set to `repeat`. Funnily it doesn't exhibit the same behaviour when using the built-in screenshot tool. We add `no-repeat` to the background specification to fix this. We also remove the backgrond of the sidebar as it is useless since it is the same colour as the body background, but it makes the miscalculation obvious should one happen again.
1 parent 3ac001b commit 6b6c352

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/assets/stylesheets/parts/a_tag.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@ body {
2222
margin: 0 auto;
2323
border: solid #999;
2424
border-width: 0 1px;
25-
background: linear-gradient(
25+
background: no-repeat
26+
linear-gradient(
2627
90deg,
2728
$C_CLAIR,
28-
$C_CLAIR $PX_BRANDING_LARG,
29-
$C_CONTAINER $PX_BRANDING_LARG,
29+
$C_CLAIR $PX_BRANDING_LARG + 1px,
30+
$C_CONTAINER $PX_BRANDING_LARG + 1px,
3031
$C_CONTAINER
3132
)
3233
#fff;

app/assets/stylesheets/parts/sidebar.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
text-align: left;
55
font-size: 0.8em;
66
line-height: 1.3;
7-
background: $C_CLAIR;
87

98
a {
109
font-weight: inherit;

0 commit comments

Comments
 (0)