Merge pull request #370 from Trim/track-account-last-seen-on

Track account last seen on

Author: Oumph

app/controllers/application_controller.rb

@@ -5,6 +5,7 @@ class ApplicationController < ActionController::Base
   protect_from_forgery with: :reset_session, prepend: true
   before_action :seo_filter
   before_action :configure_permitted_parameters, if: :devise_controller?
+  before_action :set_account_last_seen, if: :account_signed_in?
   helper_method :url_for_content, :path_for_content, :current_user, :current_stylesheet
   rescue_from Canable::Transgression, with: :error_403
 
@@ -44,6 +45,15 @@ def seo_filter
     @dont_index    = params.has_key?(:order) || (request.headers["User-Agent"] =~ /AppEngine-Google/i)
   end
 
+  def set_account_last_seen
+    # Update last seen only once a day to avoid too many database update
+    if Date.today - current_account.last_seen_on >= 1
+      # Use update_columns to ensure updated_at value is not changed with this
+      # automatic update
+      current_account.update_columns(last_seen_on: Date.today);
+    end
+  end
+
   def dont_index?
     !!@dont_index
   end

app/views/admin/accounts/index.html.haml

@@ -16,6 +16,7 @@
     %th Adresse IP courante / précédente
     %th Commentaires / contenus / étiquettes
     %th Date de création
+    %th Dernière visite
     %th Actions
     %th Changer de rôle
   - @accounts.each do |account|
@@ -73,6 +74,7 @@
             #{ image_tag "/images/icones/denied.png", alt: "masqués", title: "masqués", width: "16px" }
           %br
       %td= account.created_at.to_s(:posted)
+      %td= account.last_seen_on ? account.last_seen_on.to_s(:date) : "-"
       %td
         - if account.inactive? && account.user_id != 1
           = button_to "Activer",   [:admin, account], method: :put, class: "ok_button"

app/views/users/_recent.html.haml

@@ -10,6 +10,7 @@
       %li Rôle : #{a.display_role(@user.nodes.where(public: true).count>0)}
       %li Dernière connexion : #{a.current_sign_in_at ? l(@user.account.current_sign_in_at) : "-"}
       %li Dernière action : #{a.updated_at ? l(@user.account.updated_at) : "-"}
+      %li Dernière visite : #{a.last_seen_on ? l(@user.account.last_seen_on, format: :long) : "-"}
       %li Karma : #{a.karma} (minimum : #{a.min_karma}, maximum : #{a.max_karma})
       - if @user.homesite.present?
         %li Site perso : #{@user.homesite}

db/migrate/20230506121910_add_last_seen_on_to_accounts.rb

@@ -0,0 +1,26 @@
+class AddLastSeenOnToAccounts < ActiveRecord::Migration[5.2]
+  def change
+    add_column :accounts, :last_seen_on, :date
+
+    reversible do |set_last_seen_on|
+      set_last_seen_on.up do
+        # Set default value only for confirmed accounts
+        execute <<-SQL
+          UPDATE accounts
+            SET last_seen_on =
+              CASE
+                WHEN confirmed_at is NULL
+                  THEN NULL
+                WHEN login in ("Anonyme", "Collectif")
+                  THEN NULL
+                ELSE
+                  CURRENT_DATE()
+                END
+        SQL
+      end
+      set_last_seen_on.down do
+        # Column will be dropped nothing to do
+      end
+    end
+  end
+end

db/schema.drawio

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2023_02_25_172700) do
+ActiveRecord::Schema.define(version: 2023_05_06_121910) do
 
   create_table "accounts", id: :integer, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci", force: :cascade do |t|
     t.integer "user_id"
@@ -38,6 +38,7 @@
     t.integer "min_karma", default: 20
     t.integer "max_karma", default: 20
     t.string "uploaded_stylesheet"
+    t.date "last_seen_on"
     t.index ["confirmation_token"], name: "index_accounts_on_confirmation_token", unique: true
     t.index ["email"], name: "index_accounts_on_email", unique: true
     t.index ["login"], name: "index_accounts_on_login"