Test plus solide, et utilisation de double quote à certains endroits

Author: echarp

app/controllers/trackers_controller.rb

@@ -21,7 +21,7 @@ def index
     @tracker.state = @attrs["state"]
     @trackers = @trackers.where(state: @tracker.state)             if @attrs["state"].present?
     @trackers = @trackers.where(category_id: @tracker.category_id) if @attrs["category_id"].present?
-    if @attrs["assigned_to_user_id"] == '0'
+    if @attrs["assigned_to_user_id"] == "0"
       @trackers = @trackers.where(assigned_to_user_id: nil)
     elsif @attrs["assigned_to_user_id"].present?
       @trackers = @trackers.where(assigned_to_user_id: @tracker.assigned_to_user_id)

app/helpers/admin_helper.rb

@@ -1,14 +1,14 @@
 module AdminHelper
   def abusers
-    file = Rails.root.join('tmp/abusers.txt')
+    file = Rails.root.join("tmp/abusers.txt")
     if File.exist?(file)
-      content_tag(:ul, class: 'abusers') do
+      content_tag(:ul, class: "abusers") do
         File.readlines(file).map do |l|
           content_tag(:li, l)
         end.join.html_safe
       end
     else
-      content_tag(:p, 'aucun')
+      content_tag(:p, "aucun")
     end
   end
 end

bin/update

@@ -1,9 +1,9 @@
 #!/usr/bin/env ruby
-require 'fileutils'
+require "fileutils"
 include FileUtils
 
 # path to your application root.
-APP_ROOT = File.expand_path('..', __dir__)
+APP_ROOT = File.expand_path("..", __dir__)
 
 def system!(*args)
   system(*args) || abort("\n== Command #{args} failed ==")

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2023_10_01_132606) do
+ActiveRecord::Schema[7.1].define(version: 2023_10_01_132606) do
   create_table "accounts", id: :integer, charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t|
     t.integer "user_id"
     t.string "login", limit: 40, null: false, collation: "utf8mb4_bin"

test/controllers/comments_controller_test.rb

@@ -4,7 +4,7 @@ class CommentsControllerTest < ActionDispatch::IntegrationTest
   include Devise::Test::IntegrationHelpers
 
   setup do
-    sign_in accounts "visitor_0"
+    sign_in accounts "visitor_1"
   end
 
   test "should list comments" do

test/controllers/relevances_controller_test.rb

@@ -30,7 +30,7 @@ class RelevancesControllerTest < ActionDispatch::IntegrationTest
   end
 
   test "should not vote for" do
-    sign_in accounts "visitor_10"
+    sign_in accounts "visitor_1"
 
     assert_no_difference "comments(:one).nb_votes_for" do
       post relevance_for_node_comment_url nodes(:tracker_one), comments(:one), format: :json
@@ -42,7 +42,7 @@ class RelevancesControllerTest < ActionDispatch::IntegrationTest
   end
 
   test "should not vote against" do
-    sign_in accounts "visitor_10"
+    sign_in accounts "visitor_1"
 
     assert_no_difference "comments(:one).nb_votes_against" do
       post relevance_against_node_comment_url nodes(:tracker_one), comments(:one), format: :json

test/fixtures/comments.yml

@@ -1,35 +1,35 @@
 one:
   node: tracker_one
-  user: visitor_10
+  user: visitor_1
   title: "Hello World"
   wiki_body: "Hello World"
   materialized_path: "hello-world"
   state: published
 
 seconde:
   node: one
-  user: visitor_10
+  user: visitor_1
   title: Commentaire sur un journal
   wiki_body: Commentaire sur un journal
 
 old:
   node: old
-  user: visitor_10
+  user: visitor_1
   title: Commentaire sur un journal
   wiki_body: Commentaire sur un journal
   created_at: 2010-01-01 00:00:00
 
 poll:
   node: poll
-  user: visitor_10
+  user: visitor_1
   title: Commentaire sur un sondage
   wiki_body: Commentaire sur un sondage
   created_at: 2010-01-01 00:00:00
   materialized_path: 000079493703
 
 poll_2:
   node: poll
-  user: visitor_10
+  user: visitor_1
   title: Commentaire sur un sondage
   wiki_body: Commentaire sur un sondage
   created_at: 2010-01-01 00:00:00

test/test_helper.rb

@@ -8,6 +8,7 @@
   add_group "Long files" do |src_file|
     src_file.lines.count > 100
   end
+  load_profile "test_frameworks"
 end
 
 ENV["RAILS_ENV"] ||= "test"