gnome-desktop-thumbnailer.c: Only attempt to thumbnail internally

mtwebster · mtwebster · commit 0f6020ffc960 · 2023-04-02T11:44:59.000-04:00
if gdk-pixbuf actually supports the mime_type.

Every failed external call was being fed to the internal pixbuf,
triggering warnings when it didn't support the type.
diff --git a/libcinnamon-desktop/gnome-desktop-thumbnail.c b/libcinnamon-desktop/gnome-desktop-thumbnail.c
@@ -1260,7 +1260,7 @@ gnome_desktop_thumbnail_factory_generate_thumbnail (GnomeDesktopThumbnailFactory
     }
 
   /* Fall back to gdk-pixbuf */
-  if (pixbuf == NULL && !disabled)
+  if (!disabled && pixbuf == NULL && mimetype_supported_by_gdk_pixbuf (mime_type))
     {
       pixbuf = _gdk_pixbuf_new_from_uri_at_scale (uri, size, size, TRUE);
 

Original file line number	Diff line number	Diff line change
`@@ -1260,7 +1260,7 @@ gnome_desktop_thumbnail_factory_generate_thumbnail (GnomeDesktopThumbnailFactory`
`1260`	`1260`	`}`
`1261`	`1261`
`1262`	`1262`	`/* Fall back to gdk-pixbuf */`
`1263`		`- if (pixbuf == NULL && !disabled)`
	`1263`	`+ if (!disabled && pixbuf == NULL && mimetype_supported_by_gdk_pixbuf (mime_type))`
`1264`	`1264`	`{`
`1265`	`1265`	`pixbuf = _gdk_pixbuf_new_from_uri_at_scale (uri, size, size, TRUE);`
`1266`	`1266`