fix a null pointer deref scan-build found

JPeisach · mtwebster · commit 92d13a882e59 · 2022-11-01T09:44:13.000-04:00
diff --git a/libcinnamon-desktop/gnome-desktop-thumbnail.c b/libcinnamon-desktop/gnome-desktop-thumbnail.c
@@ -314,7 +314,7 @@ create_loader (GFile        *file,
     loader = gdk_pixbuf_loader_new_with_mime_type (mime_type, &error);
   }
 
-  if (loader == NULL) {
+  if (loader == NULL && error != NULL) {
     g_warning ("Unable to create loader for mime type %s: %s", mime_type, error->message);
     g_clear_error (&error);
     loader = gdk_pixbuf_loader_new ();

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ create_loader (GFile *file,`
`314`	`314`	`loader = gdk_pixbuf_loader_new_with_mime_type (mime_type, &error);`
`315`	`315`	`}`
`316`	`316`
`317`		`- if (loader == NULL) {`
	`317`	`+ if (loader == NULL && error != NULL) {`
`318`	`318`	`g_warning ("Unable to create loader for mime type %s: %s", mime_type, error->message);`
`319`	`319`	`g_clear_error (&error);`
`320`	`320`	`loader = gdk_pixbuf_loader_new ();`