Skip to content

Commit 5f5a1ea

Browse files
authored
radio@driglu4it: Fix context menu not opening (#8191)
* Fixes #8184 * Fix: only 100 stations downloaded due to a change in the radio browser API * Update default stations list * Update README * Update maintainer
1 parent 6c4c65d commit 5f5a1ea

File tree

6 files changed

+8
-11
lines changed

6 files changed

+8
-11
lines changed

radio@driglu4it/README.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,7 @@ The [mpv media player](https://mpv.io) is used for playing the radio channel. As
2323
For the youtube download feature you can either use [youtube-dl](https://github.com/ytdl-org/youtube-dl) or [yt-dlp](https://github.com/yt-dlp/yt-dlp). By default youtube-dl is selected. As google frequently makes technical changes to Youtube, it is highly recommended to always have the newest version of the download cli tool installed as otherwise the feature will most likely stop working after a short time. Unfortunately, the newest version in the official linux mint apt repository is usually not even close to sufficiently up to date. Therefore I highly recommend installing the software by following the official installstion instruction which can be found on the respective github page and adding a script in `/etc/cron.daily` to automate the update. I have created a gist for both [youtube-dl](https://gist.github.com/jonath92/0f6bf4606bc8a34be1bb0826c99b73d1) and [yt-dlp](https://gist.github.com/jonath92/039e998b3d3f6ba4afd5d5c671eaedf1) for this purpose.
2424

2525
## Known Issues
26-
27-
- Special characters (e.g German Umlaute) are not shown correctly on the sound applet (when the option "Show song information on the panel" is activated). This is a [bug](https://github.com/mpv-player/mpv/issues/8844) of the mpv player. There is an open [pull request](https://github.com/mpv-player/mpv/pull/8845) which will fix that. At the moment the only workaround is to compile mpv from the source of the mentioned pull request.
28-
- For some radio stations (e.g. BBC) the metadata can't be shown
2926
- It is automatically downloaded the compiled version of the mpv mpris plugin which however is only suitable for 64-bit x86 architecutres (e.g. not for the raspberry pi). In that case you unfortunately have to [build the plugin](https://github.com/hoyon/mpv-mpris#build) by yourself at the moment and place the plugin at: `~/.cinnamon/configs/radio@driglu4it/.mpris.so`.
3027

31-
## New Maintainer Needed
32-
I (https://github.com/jonath92) have been expanding and maintaining the Radio Applet for a while now, but for personal reasons I unfortunately have very little time for this project. Therefore I am looking for a new maintainer. I am still more than willing to help a new maintainer with technical questions about the code. If you need help regarding the code, just open an issue in the applet repo and notify me in the issue.
28+
## Project Status
29+
I (https://github.com/jonath92) am the maintainer of the Radio Applet. The primary focus of this project is now on providing **stability and reliability**. New features will only be added in exceptional cases where they significantly improve the core functionality or address critical user needs. Bug fixes, maintenability and compatibility improvements will continue to be prioritized. If you encounter any issues or have questions about the code, please open an issue in the applet repository.

radio@driglu4it/files/radio@driglu4it/6.4/allStations.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

radio@driglu4it/files/radio@driglu4it/6.4/radio-applet.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5719,7 +5719,7 @@ function createUpdateStationsMenuItem() {
57195719
self.setText("Updating Radio stations...");
57205720
notify("Upating Radio stations... \n\nThis can take several minutes!");
57215721
makeJsonHttpRequest({
5722-
url: "http://de1.api.radio-browser.info/json/stations",
5722+
url: "http://de1.api.radio-browser.info/json/stations?limit=100000&hidebroken=true",
57235723
onSuccess: (resp) => saveStations(resp),
57245724
onErr: (err) => {
57255725
notifyError(`Couldn't update the station list due to an error`, err.reason_phrase, { showInternetInfo: true });
@@ -5767,7 +5767,7 @@ function createRadioContextMenu(args) {
57675767
iconName: 'system-run',
57685768
text: 'Configure...',
57695769
onActivated: () => {
5770-
spawnCommandLineWithErrorLogging(`xlet-settings applet ${__meta.uuid} ${__meta.instanceId} -t 0`);
5770+
spawnCommandLineWithErrorLogging(`xlet-settings applet ${__meta.uuid} -t 0`);
57715771
}
57725772
}, {
57735773
iconName: 'edit-delete',

radio@driglu4it/info.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"author": "none",
2+
"author": "jonath92",
33
"original_author": "Driglu4it",
44
"contributors": [
55
"NikoKrause",

radio@driglu4it/src/ui/RadioContextMenu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function createRadioContextMenu(args: PopupMenuProps) {
3737
iconName: 'system-run',
3838
text: 'Configure...',
3939
onActivated: () => {
40-
spawnCommandLineWithErrorLogging(`xlet-settings applet ${__meta.uuid} ${__meta.instanceId} -t 0`)
40+
spawnCommandLineWithErrorLogging(`xlet-settings applet ${__meta.uuid} -t 0`)
4141
}
4242
}, {
4343
iconName: 'edit-delete',

radio@driglu4it/src/ui/RadioPopupMenu/UpdateStationsMenuItem.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export function createUpdateStationsMenuItem() {
6868
notify("Upating Radio stations... \n\nThis can take several minutes!");
6969

7070
makeJsonHttpRequest<RadioStation[]>({
71-
url: "http://de1.api.radio-browser.info/json/stations",
71+
url: "http://de1.api.radio-browser.info/json/stations?limit=100000&hidebroken=true",
7272
onSuccess: (resp) => saveStations(resp),
7373
onErr: (err) => {
7474
notifyError(

0 commit comments

Comments
 (0)