sound150 v13.8.1: Improves speed (#8116)

Author: claudiux

sound150@claudiux/files/sound150@claudiux/6.4/applet.js

@@ -768,7 +768,8 @@ class Sound150Applet extends Applet.TextIconApplet {
 
     on_leave_event(actor, event) {
         this.isActorEntered = false;
-        if (this.playerControl && this._activePlayer)
+        //~ if (this.playerControl && this._activePlayer)
+        if (this._activePlayer && this._players[this._activePlayer])
             this.setAppletTextIcon(this._players[this._activePlayer], true);
         else
             this.setAppletTextIcon();
@@ -876,7 +877,7 @@ class Sound150Applet extends Applet.TextIconApplet {
                     `notify-send -u critical --icon="audio-volume-overamplified-symbolic" --action="opt1=${Button1}" --action="opt2=${Button2}" "${summary}" "${body}"`,
                     (stdout, stderr, exitCode) => {
                         if (exitCode === 0) {
-                            logDebug("stdout: " + stdout + " " + typeof stdout);
+                            //~ logDebug("stdout: " + stdout + " " + typeof stdout);
                             if (stdout.startsWith("opt1")) {
                                 //~ Util.spawnCommandLineAsync("cinnamon-settings extensions -t download");
                                 Util.spawnCommandLineAsync("cinnamon-settings extensions -t 1");
@@ -1116,7 +1117,12 @@ class Sound150Applet extends Applet.TextIconApplet {
         if (!this._sound_settings.get_boolean(OVERAMPLIFICATION_KEY) && this.maxVolume > 100) {
             this.maxVolume = 100;
         }
-
+        
+        if (! this.showalbum) {
+            this.keepAlbumArtIcon = false;
+        }
+        this._iconLooping = this.showalbum;
+        
         this._volumeMax = this.maxVolume / 100 * this._volumeNorm;
         if (this.maxVolume > 100) {
             if (this._outputVolumeSection)
@@ -1193,7 +1199,7 @@ class Sound150Applet extends Applet.TextIconApplet {
         }
         this.color0_100 = color;
 
-        this._iconLooping = true;
+        this._iconLooping = this.showalbum;
 
         if (this._output && this._output.is_muted) {
             this.old_volume = this.volume;
@@ -1204,12 +1210,12 @@ class Sound150Applet extends Applet.TextIconApplet {
         this._on_sound_settings_change();
 
         this._loopArtId = null;
-        this._artLooping = true;
+        this._artLooping = this.showalbum;
         this._loopArtId = timeout_add_seconds(10, () => {
             this.loopArt();
         });
 
-        this.iconsMonitor =null;
+        this.iconsMonitor = null;
         this.iconsMonitorId == null;
         this.monitor_icon_dir();
 
@@ -1659,7 +1665,10 @@ class Sound150Applet extends Applet.TextIconApplet {
                 this._playerIcon = [icon, source === "player-path"];
         }
 
-        if (! this.showalbum) this.keepAlbumArtIcon = false;
+        if (! this.showalbum) {
+            this.keepAlbumArtIcon = false;
+            this._iconLooping = false;
+        }
 
         if (this.playerControl && this._activePlayer && this._playerIcon && this._playerIcon[0]) {
             if (source === "output") {
@@ -1672,8 +1681,8 @@ class Sound150Applet extends Applet.TextIconApplet {
                         //~ this._iconTimeoutId = timeout_add_seconds(OUTPUT_ICON_SHOW_TIME_SECONDS, () => {
                         this._iconTimeoutId = timeout_add_seconds(0, () => {
                             this.setAppletTextIcon(this._players[this._activePlayer], true);
-                            //~ return false;
-                            return this._iconLooping;
+                            return false;
+                            //~ return this._iconLooping;
                         });
                     }
                 } else {
@@ -1731,7 +1740,7 @@ class Sound150Applet extends Applet.TextIconApplet {
     }
 
     loopArt() {
-        source_remove(this._loopArtId);
+        if (this._loopArtId != null) source_remove(this._loopArtId);
         this._loopArtId = null;
         if (!this._artLooping) return;
 
@@ -1813,6 +1822,14 @@ class Sound150Applet extends Applet.TextIconApplet {
             path = null;
         }
 
+        //~ if (this.old_player === player && this.old_path === path) return;
+        if ((this.old_player === player && 
+            (typeof(this.old_path) === "string" && typeof(path) === "string" && this.old_path.split("/").pop() === path.split("/").pop()))) 
+                return;
+        this.old_player = player;
+        this.old_path = path;
+        //~ logDebug("setAppletIcon(" + player + ", " + path +")");
+        
         if (!this.allowChangeArt) return;
 
         if (this.showalbum) {
@@ -2237,22 +2254,22 @@ class Sound150Applet extends Applet.TextIconApplet {
     }
 
     _theme_set() {
-        logDebug("_theme_set()");
+        //~ logDebug("_theme_set()");
         let color = this.color0_100;
         try {
             if (!this.themeNode) {
-                logDebug("this.themeNode was not defined.");
+                //~ logDebug("this.themeNode was not defined.");
                 this.themeNode = this.actor.get_theme_node();
             }
             let defaultColor = this.themeNode.get_foreground_color();
-            logDebug("defaultColor: "+defaultColor.to_string());
+            //~ logDebug("defaultColor: "+defaultColor.to_string());
             color = defaultColor.to_string();
         } catch(e) {
             color = this.color0_100;
         }
         this.color0_100 = color;
         let _style = `color: ${color};`;
-        logDebug("_style: "+_style);
+        //~ logDebug("_style: "+_style);
         this.actor.style = _style;
         this._setStyle();
     }

sound150@claudiux/files/sound150@claudiux/6.4/lib/s150PopupMenu.js

@@ -685,7 +685,7 @@ class Player extends PopupMenu.PopupMenuSection {
             let dontDisplayArtSites = this._applet.sitesNotDisplayingAlbumArt;
             for (let site of dontDisplayArtSites) {
                 if (metadata["xesam:url"].unpack().toLowerCase().includes(site) ||
-                    metadata["mpris:artUrl"].unpack().toLowerCase().includes(site)) {
+                    (metadata["mpris:artUrl"] && metadata["mpris:artUrl"].unpack().toLowerCase().includes(site))) {
                     if (this._applet.iconsWhenNotDisplayingAlbumArt[site].length > 0) {
                         let siteIcon = this._applet.iconsWhenNotDisplayingAlbumArt[site];
                         this._trackCoverFile = `file://${siteIcon}`;

sound150@claudiux/files/sound150@claudiux/CHANGELOG.md

@@ -1,3 +1,8 @@
+### v13.8.1~20251225
+  * Improves speed.
+  * Fixes [#8115](https://github.com/linuxmint/cinnamon-spices-applets/issues/8115)
+  * Transitional version. Some bugs need to be fixed, but it works.
+
 ### v13.8.0~20251223
   * Many improvements and several bug fixes.
   * Fixes [#8052](https://github.com/linuxmint/cinnamon-spices-applets/issues/8052)

sound150@claudiux/files/sound150@claudiux/metadata.json

@@ -5,7 +5,7 @@
   "max-instances": "1",
   "description": "Enhanced sound applet",
   "hide-configuration": false,
-  "version": "13.8.0",
+  "version": "13.8.1",
   "cinnamon-version": [
     "2.8",
     "3.0",