Skip to content

Commit 0974bc9

Browse files
authored
PopupSliderMenuItem: Don't track the hover state (#12229)
Most of the time this just makes the sliders look poor. The menu item itself isn't really doing anything on click. It just makes more sense not to apply a hover style on these items.
1 parent 13ab48c commit 0974bc9

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

js/ui/popupMenu.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,10 @@ var PopupAlternatingMenuItem = class PopupAlternatingMenuItem extends PopupBaseM
657657

658658
var PopupSliderMenuItem = class PopupSliderMenuItem extends PopupBaseMenuItem {
659659
_init(value) {
660-
super._init.call(this, { activate: false });
660+
super._init.call(this, {
661+
activate: false,
662+
hover: false,
663+
});
661664

662665
this._signals.connect(this.actor, 'key-press-event', Lang.bind(this, this._onKeyPressEvent));
663666

0 commit comments

Comments
 (0)