st-theme-node.c: Fix a leak when falling back to the default theme

on 'important' ui elements.

_st_theme_get_matched_properties always returns a new GPtrArray,
even if it's empty. It can be reused in the fallback lookup.

Author: mtwebster

src/st/st-theme-node.c

@@ -468,8 +468,10 @@ ensure_properties (StThemeNode *node)
       if (node->theme)
         {
           properties = _st_theme_get_matched_properties (node->theme, node);
-          if ((!properties || properties->len == 0) && node->important)
-            properties = _st_theme_get_matched_properties_fallback (node->theme, node);
+          if (properties->len == 0 && node->important)
+            {
+              properties = _st_theme_get_matched_properties_fallback (node->theme, node, properties);
+            }
         }
 
       if (node->inline_style)

src/st/st-theme-private.h

@@ -30,7 +30,8 @@ GPtrArray *_st_theme_get_matched_properties (StTheme       *theme,
                                              StThemeNode   *node);
 
 GPtrArray *_st_theme_get_matched_properties_fallback (StTheme       *theme,
-                                                      StThemeNode   *node);
+                                                      StThemeNode   *node,
+                                                      GPtrArray     *props);
 
 /* Resolve an URL from the stylesheet to a filename */
 GFile *_st_theme_resolve_url (StTheme      *theme,

src/st/st-theme.c

@@ -1062,15 +1062,12 @@ _st_theme_get_matched_properties (StTheme        *theme,
 
 GPtrArray *
 _st_theme_get_matched_properties_fallback (StTheme        *theme,
-                                           StThemeNode    *node)
+                                           StThemeNode    *node,
+                                           GPtrArray      *props)
 {
-  GPtrArray *props;
-
   g_return_val_if_fail (ST_IS_THEME (theme), NULL);
   g_return_val_if_fail (ST_IS_THEME_NODE (node), NULL);
 
-  props = g_ptr_array_new ();
-
   if (theme->fallback_cr_stylesheet)
     add_matched_properties (theme, theme->fallback_cr_stylesheet, node, props);