gestures: Only allow window actions on ordinary windows and

dialogs.

- Check if minimize, maximize or fullscreen can be performed on
  a window before attempting it (fullscreen and maximized have the
  same conditions in muffin, except for an uncommon corner-case).
- Improve some logging.

Fixes linuxmint/mint21.2-beta#25

Author: mtwebster

js/ui/gestures/actions.js

@@ -119,6 +119,12 @@ var WorkspaceSwitchAction = class extends BaseAction {
     }
 }
 
+const actionable_window_types = [
+    Meta.WindowType.NORMAL,
+    Meta.WindowType.DIALOG,
+    Meta.WindowType.MODAL_DIALOG
+]
+
 var WindowOpAction = class extends BaseAction {
     constructor(definition, device, threshold) {
         super(definition, device, threshold);
@@ -136,23 +142,33 @@ var WindowOpAction = class extends BaseAction {
             return
         }
 
+        if (!actionable_window_types.includes(window.window_type)) {
+            return;
+        }
+
         switch (this.definition.action) {
         case "MINIMIZE":
-            window.minimize();
+            if (window.can_minimize()) {
+                window.minimize();
+            }
             break
         case "MAXIMIZE":
             if (window.maximized_horizontally && window.maximized_vertically) {
                 window.unmaximize(Meta.MaximizeFlags.BOTH);
             } 
             else {
-                window.maximize(Meta.MaximizeFlags.BOTH);
+                if (window.can_maximize()) {
+                    window.maximize(Meta.MaximizeFlags.BOTH);
+                }
             }
             break
         case "CLOSE":
             window.delete(global.get_current_time());
             break
         case "FULLSCREEN":
-            window.make_fullscreen();
+            if (window.can_maximize()) {
+                window.make_fullscreen();
+            }
             break
         case "UNFULLSCREEN":
             window.unmake_fullscreen();

js/ui/gestures/gesturesManager.js

@@ -216,7 +216,7 @@ var GesturesManager = class {
             return;
         }
 
-        debug_gesture(`Gesture started: (${DeviceTypeString[device]}) ${GestureTypeString[type]}, ${GestureDirectionString[direction]}, fingers: ${fingers}`);
+        debug_gesture(`Gesture started: (${DeviceTypeString[device]}) ${GestureTypeString[type]}, ${GestureDirectionString[direction]}, fingers: ${fingers} [${definition_match.action}]`);
 
         this.current_gesture = actions.make_action(this.settings, definition_match, device);
         this.current_gesture.begin(direction, percentage, elapsed_time);
@@ -249,7 +249,7 @@ var GesturesManager = class {
             return;
         }
 
-        debug_gesture(`${GestureTypeString[type]} end: progress: ${parseInt(percentage)} (threshold: ${this.current_gesture.threshold})`);
+        debug_gesture(`${GestureTypeString[type]} end: progress: ${parseInt(percentage)} (threshold: ${this.current_gesture.threshold}) [${def.action}]`);
 
         if (percentage < this.current_gesture.threshold) {
             debug_gesture(`Gesture threshold not met`);