Skip to content

[email protected]: fix broken aspect ratio #13163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[email protected]: fix broken aspect ratio #13163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions files/usr/share/cinnamon/desklets/[email protected]/desklet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ const Lang = imports.lang;
const Mainloop = imports.mainloop;
const Clutter = imports.gi.Clutter;
const GLib = imports.gi.GLib;
const GdkPixbuf = imports.gi.GdkPixbuf;
const Cogl = imports.gi.Cogl;
const Tweener = imports.ui.tweener;
const Util = imports.misc.util;
const Settings = imports.ui.settings;
Expand Down Expand Up @@ -149,16 +151,6 @@ class CinnamonPhotoFrameDesklet extends Desklet.Desklet {
this.update_id = Mainloop.timeout_add_seconds(this.delay, Lang.bind(this, this._update_loop));
}

_size_pic(image) {
image.disconnect(image._notif_id);

let height, width;
let ratio = Math.min(this.width / image.width, this.height / image.height);
width = ratio * image.width;
height = ratio * image.height;
image.set_size(width, height);
}

_update() {
if (this.updateInProgress) {
return;
Expand Down Expand Up @@ -226,11 +218,18 @@ class CinnamonPhotoFrameDesklet extends Desklet.Desklet {

_loadImage(filePath) {
try {
let image = St.TextureCache.get_default().load_uri_async(filePath, this.width, this.height);

image._notif_id = image.connect('notify::size', Lang.bind(this, this._size_pic));

return image;
let path = decodeURIComponent(filePath.replace(/file:\/\//g, ''));
let pixBuf = GdkPixbuf.Pixbuf.new_from_file_at_size(path, this.width, this.height);

const image = new Clutter.Image();
const pixelFormat = pixBuf.get_has_alpha() ? Cogl.PixelFormat.RGBA_8888 : Cogl.PixelFormat.RGB_888;
image.set_data(pixBuf.get_pixels(), pixelFormat, pixBuf.get_width(), pixBuf.get_height(), pixBuf.get_rowstride());

return new Clutter.Actor({
content: image,
width: pixBuf.get_width(),
height: pixBuf.get_height()
});
} catch (x) {
// Probably a non-image is in the folder
return null;
Expand Down