Skip to content

Commit a169557

Browse files
committed
l10n: Remove msgids
In English this looks OK and more or less consistent. In French and probably other Latin languages this causes a problem because the subject of the imperative isn't the same: - "Enter text" --> this is addressed to the user. - "Search in "%s" --> this describes what the program is about to do, if anything it's imperative addressed to the computer/program. Typically in French we would use the 2nd person to conjugate the first sentence in the imperative tense: "Entrez.." but we'd use the infinitive to describe the action or what we want the program to achieve: "Chercher" This makes the two entries very inconsistent and creates confusion.
1 parent 4ac4478 commit a169557

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

gresources/nemo-search-bar.glade

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@
156156
<property name="can_focus">True</property>
157157
<property name="caps_lock_warning">False</property>
158158
<property name="secondary_icon_name">system-search-symbolic</property>
159-
<property name="placeholder_text" translatable="yes">Enter text to search for</property>
160159
</object>
161160
<packing>
162161
<property name="expand">True</property>

src/nemo-query-editor.c

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -666,18 +666,8 @@ void
666666
nemo_query_editor_set_location (NemoQueryEditor *editor,
667667
GFile *location)
668668
{
669-
gchar *basename, *placeholder_text;
670-
671669
g_free (editor->priv->current_uri);
672670
editor->priv->current_uri = g_file_get_uri (location);
673-
674-
basename = g_file_get_basename (location);
675-
placeholder_text = g_strdup_printf (_("Search in %s"), basename);
676-
677-
gtk_entry_set_placeholder_text (GTK_ENTRY (editor->priv->file_entry), placeholder_text);
678-
679-
g_free (basename);
680-
g_free (placeholder_text);
681671
}
682672

683673
void
@@ -740,8 +730,7 @@ nemo_query_editor_set_active (NemoQueryEditor *editor,
740730

741731
if (g_file_is_native (base)) {
742732
gtk_widget_set_sensitive (editor->priv->content_main_box, TRUE);
743-
gtk_entry_set_placeholder_text (GTK_ENTRY (editor->priv->content_entry),
744-
_("Enter text to search for"));
733+
gtk_entry_set_placeholder_text (GTK_ENTRY (editor->priv->content_entry), "");
745734
} else {
746735
gtk_widget_set_sensitive (editor->priv->content_main_box, FALSE);
747736
gtk_entry_set_placeholder_text (GTK_ENTRY (editor->priv->content_entry),

0 commit comments

Comments
 (0)