xapp-gpu-offload-helper: Remove XAppGpuInfo.is_discrete member.

This is only used when getting a list of gpus, and isn't useful
to the end user.

This also would require package updates and rebuilds everywhere as
the GpuInfo size had changed in the header file.

Author: mtwebster

libxapp/xapp-gpu-offload-helper.c

@@ -114,6 +114,7 @@ struct _XAppGpuOffloadHelper
 
     GMutex gpu_infos_mutex;
     GList *gpu_infos; // XAppGpuInfos
+    GHashTable *discrete_infos;
 
     gboolean ready;
 
@@ -136,6 +137,7 @@ process_gpus_property (XAppGpuOffloadHelper  *helper,
 {
     GVariant *gpus;
     GList *infos = NULL;
+    GHashTable *discrete_infos = g_hash_table_new (g_direct_hash, g_direct_equal);
     gint num_children, i;
     gboolean default_found = FALSE;
 
@@ -195,9 +197,12 @@ process_gpus_property (XAppGpuOffloadHelper  *helper,
         info->display_name = g_strdup (name);
         info->env_strv = g_strdupv ((gchar **) env_strv);
         info->is_default = is_default;
-        info->is_discrete = is_discrete;
 
         infos = g_list_append (infos, info);
+        if (is_discrete)
+        {
+            g_hash_table_add (discrete_infos, info);
+        }
     }
 
     if (infos == NULL)
@@ -221,6 +226,7 @@ process_gpus_property (XAppGpuOffloadHelper  *helper,
     g_list_free_full (helper->gpu_infos, (GDestroyNotify) xapp_gpu_info_free);
     helper->gpu_infos = infos;
     helper->num_gpus = g_list_length (helper->gpu_infos);
+    helper->discrete_infos = discrete_infos;
 
     g_mutex_unlock (&helper->gpu_infos_mutex);
 }
@@ -440,6 +446,7 @@ xapp_gpu_offload_helper_dispose (GObject *object)
         helper->gpu_infos = NULL;
     }
 
+    g_clear_pointer (&helper->discrete_infos, g_hash_table_unref);
     g_clear_object (&helper->cancellable);
     g_clear_object (&helper->control);
 
@@ -639,7 +646,7 @@ xapp_gpu_offload_helper_get_offload_infos (XAppGpuOffloadHelper *helper)
         if (!info->is_default)
             continue;
 
-        if (info->is_discrete)
+        if (g_hash_table_contains (helper->discrete_infos, info))
             retval = g_list_append (retval, info);
         break;
     }
@@ -649,7 +656,7 @@ xapp_gpu_offload_helper_get_offload_infos (XAppGpuOffloadHelper *helper)
     {
         XAppGpuInfo *info = l->data;
 
-        if (!info->is_discrete)
+        if (!g_hash_table_contains (helper->discrete_infos, info))
             continue;
 
         retval = g_list_append (retval, info);

libxapp/xapp-gpu-offload-helper.h

@@ -19,7 +19,6 @@ GType xapp_gpu_info_get_type (void) G_GNUC_CONST;
  * @is_default: Whether this GPU is used by default.
  * @display_name: User-visible name of the GPU.
  * @env_strv: (array zero-terminated=1): A string array containing alternating environment variables names and values to use to enable the gpu.
- * @is_discrete: Whether this GPU is a discrete GPU.
  *
  * Information about a single GPU used for offloading. The length of @env_strv will always be an even number.
  */
@@ -29,7 +28,6 @@ struct _XAppGpuInfo
     gboolean is_default;
     gchar *display_name;
     gchar **env_strv;
-    gboolean is_discrete;
 };
 
 XAppGpuOffloadHelper    *xapp_gpu_offload_helper_get                     (void);