Merge pull request #1496 from KodeStar/bugfix/update_proxy_and_items_with_no_password

Update items with no password

Author: KodeStar

app/Http/Controllers/ItemController.php

@@ -268,13 +268,15 @@ public static function storelogic(Request $request, $id = null): Item
             ];
 
             // Proxy management
-            if (isset(getenv('HTTPS_PROXY')) || isset(getenv('https_proxy'))) {
-                $options['proxy']['http'] = getenv('HTTPS_PROXY') ?: getenv('https_proxy');
+            $httpsProxy = getenv('HTTPS_PROXY');
+            $httpsProxyLower = getenv('https_proxy');
+            if ($httpsProxy !== false || $httpsProxyLower !== false) {
+                $options['proxy']['http'] = $httpsProxy ?: $httpsProxyLower;
             }
 
             $file = $request->input('icon');
             $path_parts = pathinfo($file);
-            if (!isset($path_parts['extension'])) {
+            if (!array_key_exists('extension', $path_parts)) {
                 throw ValidationException::withMessages(['file' => 'Icon URL must have a valid file extension.']);
             }
             $extension = $path_parts['extension'];
@@ -317,7 +319,11 @@ public static function storelogic(Request $request, $id = null): Item
             $storedConfigObject = json_decode($storedItem->getAttribute('description'));
 
             $configObject = json_decode($config);
-            $configObject->password = $storedConfigObject->password;
+            if ($storedConfigObject && property_exists($storedConfigObject, 'password')) {
+                $configObject->password = $storedConfigObject->password;
+            } else {
+                $configObject->password = null;
+            }
 
             $config = json_encode($configObject);
         }