Skip to content

Commit 18367bd

Browse files
authored
Apply suggestions from code review
Signed-off-by: Howard Tseng <[email protected]>
1 parent 77d1fef commit 18367bd

File tree

2 files changed

+5
-2
lines changed
  • .github/workflows
  • root/etc/s6-overlay/s6-rc.d/init-mod-code-server-python3-poetry-install

2 files changed

+5
-2
lines changed

.github/workflows/BuildImage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ env:
1515
BASEIMAGE: "code-server" #replace
1616
MODNAME: "python3-poetry" #replace
1717
MOD_VERSION: ${{ inputs.mod_version }} #don't modify
18-
MULTI_ARCH: "true" #set to false if not needed
18+
MULTI_ARCH: "false"
1919

2020
jobs:
2121
set-vars:

root/etc/s6-overlay/s6-rc.d/init-mod-code-server-python3-poetry-install/run

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ echo "**** Setting up poetry ****"
1010
curl -sSL https://install.python-poetry.org | python3 -
1111

1212
# Add poetry to the path
13-
echo "export PATH=\"\$HOME/.local/bin:\$PATH\"" >> /root/.bashrc
13+
echo "**** ensuring poetry is in PATH ****"
14+
if ! grep -q "$HOME/.local/bin" /var/run/s6/container_environment/PATH; then
15+
printf ':$HOME/.local/bin' >> /var/run/s6/container_environment/PATH
16+
fi
1417

1518
echo "**** poetry setup complete ****"

0 commit comments

Comments
 (0)