Merge pull request #760 from Dominaezzz/patch-1

Allow user to specify which version of rffmpeg to download

Author: aptalca

.github/workflows/BuildImage.yml

@@ -20,7 +20,7 @@ jobs:
           echo "BASEIMAGE=${{ env.BASEIMAGE }}" >> $GITHUB_OUTPUT
           echo "MODNAME=${{ env.MODNAME }}" >> $GITHUB_OUTPUT
           # **** If the mod needs to be versioned, set the versioning logic below. Otherwise leave as is. ****
-          MOD_VERSION=""
+          MOD_VERSION=$(curl -s https://api.github.com/repos/joshuaboniface/rffmpeg/commits/master | jq -rc ".sha")
           echo "MOD_VERSION=${MOD_VERSION}" >> $GITHUB_OUTPUT
     outputs:
       GITHUB_REPO: ${{ steps.outputs.outputs.GITHUB_REPO }}

Dockerfile

@@ -1,8 +1,25 @@
 # syntax=docker/dockerfile:1
 
+FROM ghcr.io/linuxserver/baseimage-alpine:3.17 as buildstage
+
+ARG MOD_VERSION
+
+RUN \
+  echo "**** grab rffmpeg ****" && \
+  mkdir -p /root-layer/usr/local/bin/ && \
+  MOD_VERSION=${MOD_VERSION:-master} && \
+  curl -fo \
+    /root-layer/usr/local/bin/rffmpeg -L \
+    "https://raw.githubusercontent.com/joshuaboniface/rffmpeg/${MOD_VERSION}/rffmpeg" && \
+  chmod +x /root-layer/usr/local/bin/rffmpeg
+
+# copy local files
+COPY root/ /root-layer/
+
+## Single layer deployed image ##
 FROM scratch
 
 LABEL maintainer="junkman690"
 
-# copy local files
-COPY root/ /
+# Add files from buildstage
+COPY --from=buildstage /root-layer/ /

root/etc/s6-overlay/s6-rc.d/init-mod-jellyfin-rffmpeg-setup/run

@@ -13,13 +13,6 @@ else
     cp /defaults/rffmpeg.yml.sample /config/rffmpeg/rffmpeg.yml
 fi
 
-#Grab rffmpeg
-mkdir -p /usr/local/bin/
-echo "**** Grabbing rffmpeg from upstream ****"
-rm -rf /usr/local/bin/rffmpeg
-curl -L -o /usr/local/bin/rffmpeg https://raw.githubusercontent.com/joshuaboniface/rffmpeg/master/rffmpeg
-chmod +x /usr/local/bin/rffmpeg
-
 ##Update rffmpeg.yml
 sed -i 's~#persist: "/run/shm"~persist: "/dev/shm"~' /config/rffmpeg/rffmpeg.yml
 sed -i 's~#state: "/var/lib/rffmpeg"~state: "/config/rffmpeg"~' /config/rffmpeg/rffmpeg.yml