[FEAT] Ship with a docker health check

[felipecrs]

Is this a new feature request?

• I have searched the existing issues

Wanted change

It would be nice if the webtop docker images shipped with a docker health check preconfigured.

Reason for change

A health check is good for several reasons. I can elaborate if needed.

Proposed code change

https://docs.docker.com/reference/dockerfile/#healthcheck

[thelamer]

I will implement health checks when docker does so on their official images that has always been my stance.

I am going to let you in on a little secret though, they never will.

[felipecrs]

Fair enough, @thelamer.

I was mainly looking for a health check endpoint I could ping, though.

Do you have any suggestions?

I mean, I could curl -fsS -k -I -o /dev/null http://127.0.0.1:3001 which would return me the entry html, but that doesn't really tell much I guess.

[thelamer]

No I have no suggestions that would reflect the operational state of the container and spinning up and down a video stream to get a green checkmark in a docker management dashboard somewhere is dumb.

[felipecrs]

I agree.

I'll stick with curl -fsS -k -I -o /dev/null https://127.0.0.1:3001 for now, which is better than nothing.

Thank you!

[felipecrs]

I guess what I am really look for is for a health endpoint in selkies.

[felipecrs]

spinning up and down a video stream to get a green checkmark in a docker management dashboard somewhere is dumb.

To clarify, I agree that spinning up a video stream is too much work for a health check.

But I don't agree with your "green checkmark" claim.

One could use it in k8s liveness probes to automatically restart the pod once it becomes unhealthy.

I will do the same with docker (https://github.com/willfarrell/docker-autoheal).

[felipecrs]

Looks like selkies already has a health check endpoint:

https://github.com/selkies-project/selkies/blob/6cbd7f04cdf88a4cf90dbdbc398407746718e33d/src/selkies/legacy/signalling_web.py#L214-L215

I didn't dig into webtop and baseimage-selkies too much, would you know how to access it?

From default.conf I cannot really tell.