Skip to content

Commit 4eae211

Browse files
authored
fix: release-please is not triggering deployments (#1071)
#### Motivation Latest master release did not trigger a deployment #### Modification Attempt to upgrade the release process to the same as other parts of LINZ #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated - [ ] Docs updated - [ ] Issue linked in Title
1 parent bee8cc8 commit 4eae211

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/push.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ jobs:
99
steps:
1010
- uses: linz/action-typescript@9bf69b0f313b3525d3ba3116f26b1aff7eb7a6c0 # v3.1.0
1111
with:
12-
node-version: 23.x
12+
node-version: 24.x

.github/workflows/release-please.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,11 @@ jobs:
1010
environment:
1111
name: prod
1212
outputs:
13-
releases_created: ${{ steps.release.outputs.releases_created }}
13+
release_created: ${{ steps.release.outputs.release_created }}
1414
steps:
15-
- uses: google-github-actions/release-please-action@v3
15+
- uses: google-github-actions/release-please-action@v4
1616
id: release
1717
with:
18-
release-type: node
1918
token: ${{ secrets.LI_GITHUB_ACTION_TOKEN }}
2019

2120
publish-release:
@@ -29,11 +28,11 @@ jobs:
2928
environment:
3029
name: prod
3130

32-
if: ${{ needs.release-please.outputs.releases_created }}
31+
if: ${{ needs.release-please.outputs.release_created == 'true' }}
3332
steps:
3433
- uses: linz/action-typescript@9bf69b0f313b3525d3ba3116f26b1aff7eb7a6c0 # v3.1.0
3534
with:
36-
node-version: 23.x
35+
node-version: 24.x
3736

3837
- name: (Prod) Configure AWS Credentials
3938
uses: aws-actions/configure-aws-credentials@010d0da01d0b5a38af31e9c3470dbfdabdecca3a # v4

0 commit comments

Comments
 (0)