diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5d7794e..7ba8a3b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -43,7 +43,8 @@ jobs: - name: Update manifests run: | # this is quite naive, but i don't think we need more for now - sed -i "s/dev/${TAG}/g" config/default/manager_image_patch.yaml + # there is a bug here as the previous sed replace the "dev" pattern in the tag and in the org name, somthing with capturing group seems better + sed -r "/image:/ s/^(.*):(.*)$/\1:${TAG}/g" config/default/manager_image_patch.yaml kustomize build config/default/ > infrastructure-components.yaml - name: Release uses: softprops/action-gh-release@v2 diff --git a/config/default/manager_image_patch.yaml b/config/default/manager_image_patch.yaml index b739755..3ae16fb 100644 --- a/config/default/manager_image_patch.yaml +++ b/config/default/manager_image_patch.yaml @@ -6,8 +6,6 @@ metadata: spec: template: spec: - imagePullSecrets: - - name: capmvm-private-image-cred containers: - image: ghcr.io/liquidmetal-dev/cluster-api-provider-microvm:dev name: manager