From 709386356891a6333d4337cad25128849e2ebc0c Mon Sep 17 00:00:00 2001 From: faelis Date: Tue, 22 Apr 2025 18:51:09 +0200 Subject: [PATCH 1/2] Fix: the sed that help to build the 'infrastructure-components.yaml' The actual sed replace the 'dev' pattern in 2 places in the manager_image_patch.yaml : - The image is replaced (that's good) - The 'dev' suffix of the 'liquidmetal-dev' org name is also replaced, and kubelet/containerd try to pull the ghcr.io/liquidmetal-v0.10.1/cluster-api-provider-microvm:v0.10.1 (that's not good :)) Using capturing group on matching line could fix the bug --- .github/workflows/release.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5d7794e..7ba8a3b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -43,7 +43,8 @@ jobs: - name: Update manifests run: | # this is quite naive, but i don't think we need more for now - sed -i "s/dev/${TAG}/g" config/default/manager_image_patch.yaml + # there is a bug here as the previous sed replace the "dev" pattern in the tag and in the org name, somthing with capturing group seems better + sed -r "/image:/ s/^(.*):(.*)$/\1:${TAG}/g" config/default/manager_image_patch.yaml kustomize build config/default/ > infrastructure-components.yaml - name: Release uses: softprops/action-gh-release@v2 From a303014ee78383ba9da884207e0beb12d736108f Mon Sep 17 00:00:00 2001 From: faelis Date: Tue, 22 Apr 2025 19:30:42 +0200 Subject: [PATCH 2/2] fix: imagePullSecrets is no longer needed --- config/default/manager_image_patch.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/config/default/manager_image_patch.yaml b/config/default/manager_image_patch.yaml index b739755..3ae16fb 100644 --- a/config/default/manager_image_patch.yaml +++ b/config/default/manager_image_patch.yaml @@ -6,8 +6,6 @@ metadata: spec: template: spec: - imagePullSecrets: - - name: capmvm-private-image-cred containers: - image: ghcr.io/liquidmetal-dev/cluster-api-provider-microvm:dev name: manager