Skip to content

hidden attribute without '?' prefix doesn't work #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
craigberry wants to merge 1 commit into from
Closed

hidden attribute without '?' prefix doesn't work #1416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/lit-dev-content/site/articles/article/lit-for-polymer-users.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,10 +577,10 @@ When migrating a Polymer `dom-if` to Lit, you have several choices:

- Use a simple JavaScript conditional. Lit removes and discards the conditional DOM when a condition changes to falsy. `dom-if` does the same thing if you set the `restamp` property to `true`.

- Use the standard `hidden` attribute to hide the content without removing it from the page.
- Use the standard `hidden` attribute to hide the content without removing it from the page. Note the use here of the `?` prefix that causes boolean attributes to be added or removed rather than simply set (because `hidden="false"` is still hidden).

```html
<header hidden=${this.headerHidden}>
<header ?hidden=${this.headerHidden}>
```

This is quite lightweight. However, the DOM is created on first render even if the condition is false.
Expand Down
Loading