Multiple disposing fixes

Author: DTraitor

LiteDB/Engine/Disk/DiskService.cs

@@ -55,7 +55,15 @@ public DiskService(
             {
                 LOG($"creating new database: '{Path.GetFileName(_dataFactory.Name)}'", "DISK");
 
-                this.Initialize(_dataPool.Writer.Value, settings.Collation, settings.InitialSize);
+                try
+                {
+                    this.Initialize(_dataPool.Writer.Value, settings.Collation, settings.InitialSize);
+                }
+                catch (Exception ex)
+                {
+                    LOG($"Error while initializing DiskService: {ex.Message}", "ERROR");
+                    throw;
+                }
             }
 
             // if not readonly, force open writable datafile

LiteDB/Engine/Services/RebuildService.cs

@@ -51,14 +51,15 @@ public long Rebuild(RebuildOptions options)
                 // open file reader and ready to import to new temp engine instance
                 reader.Open();
 
-                // open new engine to recive all data readed from FileReader
-                using (var engine = new LiteEngine(new EngineSettings
-                {
-                    Filename = tempFilename,
-                    Collation = options.Collation,
-                    Password = options.Password,
-                }))
+                try
                 {
+                    // open new engine to recive all data readed from FileReader
+                    using var engine = new LiteEngine(new EngineSettings
+                    {
+                        Filename = tempFilename,
+                        Collation = options.Collation,
+                        Password = options.Password,
+                    });
                     // copy all database to new Log file with NO checkpoint during all rebuild
                     engine.Pragma(Pragmas.CHECKPOINT, 0);
 
@@ -85,6 +86,11 @@ public long Rebuild(RebuildOptions options)
                     // after rebuild, copy log bytes into data file
                     engine.Checkpoint();
                 }
+                catch (Exception)
+                {
+                    File.Delete(tempFilename);
+                    throw;
+                }
             }
 
             // if log file exists, rename as backup file

LiteDB/Engine/Services/TransactionService.cs

@@ -398,32 +398,40 @@ protected virtual void Dispose(bool dispose)
                 return;
             }
 
-            ENSURE(_state != TransactionState.Disposed, "transaction must be active before call Done");
-
-            // clean snapshots if there is no commit/rollback
-            if (_state == TransactionState.Active && _snapshots.Count > 0)
+            try
             {
-                // release writable snapshots
-                foreach (var snapshot in _snapshots.Values.Where(x => x.Mode == LockMode.Write))
-                {
-                    // discard all dirty pages
-                    _disk.DiscardDirtyPages(snapshot.GetWritablePages(true, true).Select(x => x.Buffer));
 
-                    // discard all clean pages
-                    _disk.DiscardCleanPages(snapshot.GetWritablePages(false, true).Select(x => x.Buffer));
-                }
+                ENSURE(_state != TransactionState.Disposed, "transaction must be active before call Done");
 
-                // release buffers in read-only snaphosts
-                foreach (var snapshot in _snapshots.Values.Where(x => x.Mode == LockMode.Read))
+                // clean snapshots if there is no commit/rollback
+                if (_state == TransactionState.Active && _snapshots.Count > 0)
                 {
-                    foreach (var page in snapshot.LocalPages)
+                    // release writable snapshots
+                    foreach (var snapshot in _snapshots.Values.Where(x => x.Mode == LockMode.Write))
                     {
-                        page.Buffer.Release();
+                        // discard all dirty pages
+                        _disk.DiscardDirtyPages(snapshot.GetWritablePages(true, true).Select(x => x.Buffer));
+
+                        // discard all clean pages
+                        _disk.DiscardCleanPages(snapshot.GetWritablePages(false, true).Select(x => x.Buffer));
                     }
 
-                    snapshot.CollectionPage?.Buffer.Release();
+                    // release buffers in read-only snaphosts
+                    foreach (var snapshot in _snapshots.Values.Where(x => x.Mode == LockMode.Read))
+                    {
+                        foreach (var page in snapshot.LocalPages)
+                        {
+                            page.Buffer.Release();
+                        }
+
+                        snapshot.CollectionPage?.Buffer.Release();
+                    }
                 }
             }
+            catch (Exception ex)
+            {
+                LOG($"Error while disposing TransactionService: {ex.Message}", "ERROR");
+            }
 
             _reader.Dispose();