fix: accessing potentially lazy attributes before check on update

Author: Glinte

advanced_alchemy/repository/_async.py

@@ -1510,17 +1510,17 @@ async def update(
 
                     # Handle relationships by merging objects into session first
                     for relationship in mapper.mapper.relationships:
-                        if (new_value := getattr(data, relationship.key, MISSING)) is not MISSING:
-                            # Skip relationships that cannot be handled by generic merge operations
-                            if relationship.viewonly or relationship.lazy in {  # pragma: no cover
-                                "write_only",
-                                "dynamic",
-                                "raise",
-                                "raise_on_sql",
-                            }:
-                                # Skip relationships with incompatible lazy loading strategies
-                                continue
+                        # Skip relationships that cannot be handled by generic merge operations
+                        if relationship.viewonly or relationship.lazy in {  # pragma: no cover
+                            "write_only",
+                            "dynamic",
+                            "raise",
+                            "raise_on_sql",
+                        }:
+                            # Skip relationships with incompatible lazy loading strategies
+                            continue
 
+                        if (new_value := getattr(data, relationship.key, MISSING)) is not MISSING:
                             if isinstance(new_value, list):
                                 merged_values = [  # pyright: ignore
                                     await self.session.merge(item, load=False)  # pyright: ignore

advanced_alchemy/repository/_sync.py

@@ -1511,17 +1511,17 @@ def update(
 
                     # Handle relationships by merging objects into session first
                     for relationship in mapper.mapper.relationships:
-                        if (new_value := getattr(data, relationship.key, MISSING)) is not MISSING:
-                            # Skip relationships that cannot be handled by generic merge operations
-                            if relationship.viewonly or relationship.lazy in {  # pragma: no cover
-                                "write_only",
-                                "dynamic",
-                                "raise",
-                                "raise_on_sql",
-                            }:
-                                # Skip relationships with incompatible lazy loading strategies
-                                continue
+                        # Skip relationships that cannot be handled by generic merge operations
+                        if relationship.viewonly or relationship.lazy in {  # pragma: no cover
+                            "write_only",
+                            "dynamic",
+                            "raise",
+                            "raise_on_sql",
+                        }:
+                            # Skip relationships with incompatible lazy loading strategies
+                            continue
 
+                        if (new_value := getattr(data, relationship.key, MISSING)) is not MISSING:
                             if isinstance(new_value, list):
                                 merged_values = [  # pyright: ignore
                                     self.session.merge(item, load=False)  # pyright: ignore