Skip to content

Commit 24701eb

Browse files
authored
fix: constrained 0 length lists (#570)
1 parent 67c5720 commit 24701eb

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

polyfactory/value_generators/constrained_collections.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def handle_constrained_collection(
4646
collection: set[T] | list[T] = set() if (collection_type in (frozenset, set) or unique_items) else []
4747

4848
try:
49-
length = factory.__random__.randint(min_items, max_items) or 1
49+
length = factory.__random__.randint(min_items, max_items)
5050
while (i := len(collection)) < length:
5151
if field_build_parameters and len(field_build_parameters) > i:
5252
build_params = field_build_parameters[i]

tests/constraints/test_frozen_set_constraints.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,4 @@ def test_handle_constrained_set_with_different_types(t_type: Any) -> None:
8383
field_meta=FieldMeta(name="test", annotation=frozenset, random=Random()),
8484
item_type=t_type,
8585
)
86-
assert len(result) > 0
86+
assert len(result) >= 0

tests/constraints/test_list_constraints.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def test_handle_constrained_list_with_different_types(t_type: Any) -> None:
8989
field_meta=field_meta.children[0], # type: ignore[index]
9090
item_type=t_type,
9191
)
92-
assert len(result) > 0
92+
assert len(result) >= 0
9393

9494

9595
def test_handle_unique_items() -> None:

tests/constraints/test_set_constraints.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,4 @@ def test_handle_constrained_set_with_different_types(t_type: Any) -> None:
8383
field_meta=FieldMeta(name="test", annotation=set, random=Random()),
8484
item_type=t_type,
8585
)
86-
assert len(result) > 0
86+
assert len(result) >= 0

0 commit comments

Comments
 (0)