Skip to content

Commit 4106b07

Browse files
authored
fix(oracle): correct service names used in fixture (#73)
1 parent 9a0eedf commit 4106b07

File tree

3 files changed

+197
-194
lines changed

3 files changed

+197
-194
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ repos:
1919

2020
# Ruff replaces black, flake8, autoflake and isort
2121
- repo: https://github.com/charliermarsh/ruff-pre-commit
22-
rev: "v0.11.4" # make sure this is always consistent with hatch configs
22+
rev: "v0.11.6" # make sure this is always consistent with hatch configs
2323
hooks:
2424
- id: ruff
2525
args: [--config, ./pyproject.toml]

src/pytest_databases/docker/oracle.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -142,38 +142,38 @@ def oracle_18c_service(
142142

143143
# alias to the latest
144144
@pytest.fixture(autouse=False, scope="session")
145-
def oracle_service(oracle23ai_service: OracleService) -> OracleService:
146-
return oracle23ai_service
145+
def oracle_service(oracle_23ai_service: OracleService) -> OracleService:
146+
return oracle_23ai_service
147147

148148

149149
@pytest.fixture(autouse=False, scope="session")
150150
def oracle_18c_connection(
151-
oracle18c_service: OracleService,
151+
oracle_18c_service: OracleService,
152152
) -> Generator[oracledb.Connection, None, None]:
153153
with oracledb.connect(
154-
host=oracle18c_service.host,
155-
port=oracle18c_service.port,
156-
user=oracle18c_service.user,
157-
service_name=oracle18c_service.service_name,
158-
password=oracle18c_service.password,
154+
host=oracle_18c_service.host,
155+
port=oracle_18c_service.port,
156+
user=oracle_18c_service.user,
157+
service_name=oracle_18c_service.service_name,
158+
password=oracle_18c_service.password,
159159
) as db_connection:
160160
yield db_connection
161161

162162

163163
@pytest.fixture(autouse=False, scope="session")
164164
def oracle_23ai_connection(
165-
oracle23ai_service: OracleService,
165+
oracle_23ai_service: OracleService,
166166
) -> Generator[oracledb.Connection, None, None]:
167167
with oracledb.connect(
168-
host=oracle23ai_service.host,
169-
port=oracle23ai_service.port,
170-
user=oracle23ai_service.user,
171-
service_name=oracle23ai_service.service_name,
172-
password=oracle23ai_service.password,
168+
host=oracle_23ai_service.host,
169+
port=oracle_23ai_service.port,
170+
user=oracle_23ai_service.user,
171+
service_name=oracle_23ai_service.service_name,
172+
password=oracle_23ai_service.password,
173173
) as db_connection:
174174
yield db_connection
175175

176176

177177
@pytest.fixture(autouse=False, scope="session")
178-
def oracle_startup_connection(oracle23ai_startup_connection: oracledb.Connection) -> oracledb.Connection:
179-
return oracle23ai_startup_connection
178+
def oracle_startup_connection(oracle_23ai_startup_connection: oracledb.Connection) -> oracledb.Connection:
179+
return oracle_23ai_startup_connection

0 commit comments

Comments
 (0)