refactor: remove unnecessary type casts for event channel in integration and unit tests

Author: cofin

tests/integration/test_adapters/test_asyncmy/test_extensions/test_events.py

@@ -1,7 +1,7 @@
 # pyright: reportPrivateUsage=false, reportAttributeAccessIssue=false, reportArgumentType=false
 """AsyncMy integration tests for the EventChannel queue backend."""
 
-from typing import TYPE_CHECKING, Any, cast
+from typing import Any
 
 import pytest
 from pytest_databases.docker.mysql import MySQLService
@@ -10,9 +10,6 @@
 from sqlspec.adapters.asyncmy import AsyncmyConfig
 from sqlspec.migrations.commands import AsyncMigrationCommands
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import AsyncEventChannel
-
 pytestmark = pytest.mark.xdist_group("mysql")
 
 
@@ -41,7 +38,7 @@ async def test_asyncmy_event_channel_queue_fallback(mysql_service: MySQLService,
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     assert channel._backend_name == "table_queue"
 
@@ -87,7 +84,7 @@ async def test_asyncmy_event_channel_multiple_messages(mysql_service: MySQLServi
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_ids = [
         await channel.publish("multi_test", {"index": 0}),
@@ -134,7 +131,7 @@ async def test_asyncmy_event_channel_nack_redelivery(mysql_service: MySQLService
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_id = await channel.publish("nack_test", {"retry": True})
 

tests/integration/test_adapters/test_asyncpg/test_extensions/test_events.py

@@ -1,14 +1,11 @@
 # pyright: reportPrivateUsage=false
 """AsyncPG integration tests for the EventChannel native backend."""
 
-from typing import cast
-
 import pytest
 from pytest_databases.docker.postgres import PostgresService
 
 from sqlspec import SQLSpec
 from sqlspec.adapters.asyncpg import AsyncpgConfig
-from sqlspec.extensions.events import AsyncEventChannel
 
 pytestmark = pytest.mark.xdist_group("postgres")
 
@@ -30,7 +27,7 @@ async def test_asyncpg_native_event_channel(postgres_service: PostgresService) -
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast(AsyncEventChannel, spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     assert channel._backend_name == "listen_notify"
 

tests/integration/test_adapters/test_asyncpg/test_extensions/test_events_listen_notify.py

@@ -2,17 +2,14 @@
 """PostgreSQL LISTEN/NOTIFY event channel tests for asyncpg adapter."""
 
 import asyncio
-from typing import TYPE_CHECKING, Any, cast
+from typing import Any
 
 import pytest
 
 from sqlspec import SQLSpec
 from sqlspec.adapters.asyncpg import AsyncpgConfig
 from sqlspec.migrations.commands import AsyncMigrationCommands
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import AsyncEventChannel
-
 pytestmark = pytest.mark.xdist_group("postgres")
 
 
@@ -32,7 +29,7 @@ async def test_asyncpg_listen_notify_publish_and_ack(postgres_service: "Any") ->
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     assert channel._backend_name == "listen_notify"
 
@@ -58,7 +55,7 @@ async def test_asyncpg_listen_notify_message_delivery(postgres_service: "Any") -
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     received: list[Any] = []
 
@@ -105,7 +102,7 @@ async def test_asyncpg_hybrid_listen_notify_durable(postgres_service: "Any", tmp
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     assert channel._backend_name == "listen_notify_durable"
 
@@ -147,7 +144,7 @@ async def test_asyncpg_listen_notify_metadata(postgres_service: "Any") -> None:
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     received: list[Any] = []
 

tests/integration/test_adapters/test_duckdb/test_extensions/test_events.py

@@ -1,17 +1,11 @@
 """DuckDB integration tests for EventChannel queue fallback."""
 
-from typing import TYPE_CHECKING, cast
-
 import pytest
 
 from sqlspec import SQLSpec
 from sqlspec.adapters.duckdb import DuckDBConfig
 from sqlspec.migrations.commands import SyncMigrationCommands
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import SyncEventChannel
-
-
 @pytest.mark.integration
 @pytest.mark.duckdb
 def test_duckdb_event_channel_queue_fallback(tmp_path) -> None:
@@ -31,7 +25,7 @@ def test_duckdb_event_channel_queue_fallback(tmp_path) -> None:
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("SyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_id = channel.publish("notifications", {"action": "duck"})
     iterator = channel.iter_events("notifications", poll_interval=0.05)

tests/integration/test_adapters/test_oracledb/test_extensions/test_events.py

@@ -4,7 +4,7 @@
 import asyncio
 import os
 from textwrap import dedent
-from typing import TYPE_CHECKING, cast
+from typing import TYPE_CHECKING
 
 import pytest
 
@@ -15,8 +15,6 @@
 if TYPE_CHECKING:
     from pathlib import Path
 
-    from sqlspec.extensions.events import AsyncEventChannel, SyncEventChannel
-
 pytestmark = pytest.mark.xdist_group("oracle")
 
 ORACLE_HOST = os.environ.get("ORACLE_TEST_HOST", "127.0.0.1")
@@ -108,7 +106,7 @@ def test_oracle_sync_event_channel_queue_fallback(tmp_path: "Path") -> None:
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("SyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_id = channel.publish("notifications", {"action": "oracle"})
     iterator = channel.iter_events("notifications", poll_interval=0.5)
@@ -148,7 +146,7 @@ async def test_oracle_async_event_channel_queue_fallback(tmp_path: "Path") -> No
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_id = await channel.publish("notifications", {"action": "oracle_async"})
     iterator = channel.iter_events("notifications", poll_interval=0.5)

tests/integration/test_adapters/test_psqlpy/test_extensions/test_events.py

@@ -2,7 +2,6 @@
 """Psqlpy integration tests for the EventChannel queue backend."""
 
 import asyncio
-from typing import TYPE_CHECKING, cast
 
 import pytest
 from pytest_databases.docker.postgres import PostgresService
@@ -11,9 +10,6 @@
 from sqlspec.adapters.psqlpy import PsqlpyConfig
 from sqlspec.migrations.commands import AsyncMigrationCommands
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import AsyncEventChannel
-
 pytestmark = pytest.mark.xdist_group("postgres")
 
 
@@ -40,7 +36,7 @@ async def test_psqlpy_event_channel_queue_fallback(tmp_path, postgres_service: P
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_id = await channel.publish("notifications", {"action": "psqlpy"})
     iterator = channel.iter_events("notifications", poll_interval=0.1)

tests/integration/test_adapters/test_psqlpy/test_extensions/test_events_listen_notify.py

@@ -2,17 +2,14 @@
 """PostgreSQL LISTEN/NOTIFY event channel tests for psqlpy adapter."""
 
 import asyncio
-from typing import TYPE_CHECKING, Any, cast
+from typing import Any
 
 import pytest
 
 from sqlspec import SQLSpec
 from sqlspec.adapters.psqlpy import PsqlpyConfig
 from sqlspec.migrations.commands import AsyncMigrationCommands
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import AsyncEventChannel
-
 pytestmark = pytest.mark.xdist_group("postgres")
 
 
@@ -31,7 +28,7 @@ async def test_psqlpy_listen_notify_native(postgres_service: "Any") -> None:
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     received: list[Any] = []
 
@@ -78,7 +75,7 @@ async def test_psqlpy_listen_notify_hybrid(postgres_service: "Any", tmp_path) ->
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     received: list[Any] = []
 

tests/integration/test_adapters/test_psycopg/test_extensions/test_events.py

@@ -2,7 +2,6 @@
 """Psycopg integration tests for the EventChannel queue backend."""
 
 import asyncio
-from typing import TYPE_CHECKING, cast
 
 import pytest
 from pytest_databases.docker.postgres import PostgresService
@@ -11,9 +10,6 @@
 from sqlspec.adapters.psycopg import PsycopgAsyncConfig, PsycopgSyncConfig
 from sqlspec.migrations.commands import AsyncMigrationCommands, SyncMigrationCommands
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import AsyncEventChannel, SyncEventChannel
-
 pytestmark = pytest.mark.xdist_group("postgres")
 
 
@@ -38,7 +34,7 @@ def test_psycopg_sync_event_channel_queue_fallback(tmp_path, postgres_service: P
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("SyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_id = channel.publish("notifications", {"action": "queue"})
     iterator = channel.iter_events("notifications", poll_interval=0.1)
@@ -74,7 +70,7 @@ async def test_psycopg_async_event_channel_queue_fallback(tmp_path, postgres_ser
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     event_id = await channel.publish("notifications", {"action": "async_queue"})
     iterator = channel.iter_events("notifications", poll_interval=0.1)

tests/integration/test_adapters/test_psycopg/test_extensions/test_events_listen_notify.py

@@ -3,17 +3,14 @@
 
 import asyncio
 import time
-from typing import TYPE_CHECKING, Any, cast
+from typing import Any
 
 import pytest
 
 from sqlspec import SQLSpec
 from sqlspec.adapters.psycopg import PsycopgAsyncConfig, PsycopgSyncConfig
 from sqlspec.migrations.commands import AsyncMigrationCommands, SyncMigrationCommands
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import AsyncEventChannel, SyncEventChannel
-
 pytestmark = pytest.mark.xdist_group("postgres")
 
 
@@ -31,7 +28,7 @@ def test_psycopg_sync_listen_notify(postgres_service: "Any") -> None:
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("SyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
     backend = channel._backend
     assert "_ensure_sync_listener" in dir(backend)
 
@@ -62,7 +59,7 @@ async def test_psycopg_async_listen_notify(postgres_service: "Any") -> None:
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     received: list[Any] = []
 
@@ -101,7 +98,7 @@ def test_psycopg_sync_hybrid_listen_notify_durable(postgres_service: "Any", tmp_
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("SyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     received: list[Any] = []
     listener = channel.listen("alerts", lambda message: received.append(message), poll_interval=0.2)
@@ -137,7 +134,7 @@ async def test_psycopg_async_hybrid_listen_notify_durable(postgres_service: "Any
 
     spec = SQLSpec()
     spec.add_config(config)
-    channel = cast("AsyncEventChannel", spec.event_channel(config))
+    channel = spec.event_channel(config)
 
     received: list[Any] = []
 

tests/integration/test_adapters/test_spanner/test_extensions/test_events/test_events.py

@@ -1,16 +1,11 @@
 """Integration tests for Spanner EventChannel queue backend."""
 
-from typing import TYPE_CHECKING, cast
-
 import pytest
 
 from sqlspec import SQLSpec
 from sqlspec.adapters.spanner import SpannerSyncConfig
 from sqlspec.adapters.spanner.events import SpannerSyncEventQueueStore
 
-if TYPE_CHECKING:
-    from sqlspec.extensions.events import SyncEventChannel
-
 pytestmark = [pytest.mark.spanner, pytest.mark.integration]
 
 
@@ -20,7 +15,7 @@ def test_spanner_event_channel_queue_fallback(
     """Queue-backed events work on Spanner via the table queue backend."""
     spec = SQLSpec()
     spec.add_config(spanner_events_config)
-    channel = cast("SyncEventChannel", spec.event_channel(spanner_events_config))
+    channel = spec.event_channel(spanner_events_config)
 
     event_id = channel.publish("notifications", {"action": "spanner_event"})
 
@@ -88,7 +83,7 @@ def test_spanner_event_metadata_roundtrip(
     """Events with metadata are correctly stored and retrieved."""
     spec = SQLSpec()
     spec.add_config(spanner_events_config)
-    channel = cast("SyncEventChannel", spec.event_channel(spanner_events_config))
+    channel = spec.event_channel(spanner_events_config)
 
     metadata = {"source": "test", "priority": 1}
     event_id = channel.publish("metadata_test", {"data": "value"}, metadata=metadata)